Issue 2989002: Add methods for determining which PrefStore contains a given preference, and ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2989002: Add methods for determining which PrefStore contains a given preference, and ... (Closed)

Created:
10 years, 5 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
Bernhard Bauer, Mattias Nissler (ping if slow)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add methods for determining which PrefStore contains a given preference, and for which store is currently controlling it. BUG=48952 TEST=covered by unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52305

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -27 lines)			Patch
M	chrome/browser/pref_service.h	View	1 chunk	+19 lines, -2 lines	0 comments	Download
M	chrome/browser/pref_service.cc	View	1 chunk	+16 lines, -1 line	0 comments	Download
M	chrome/browser/pref_value_store.h	View	2 chunks	+16 lines, -4 lines	0 comments	Download
M	chrome/browser/pref_value_store.cc	View	2 chunks	+39 lines, -12 lines	0 comments	Download
M	chrome/browser/pref_value_store_unittest.cc	View	4 chunks	+77 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

Thanks. Mattias, will you fix the condition for sync? - Pam

10 years, 5 months ago (2010-07-13 16:42:39 UTC) #3

Mattias Nissler (ping if slow)

On 2010/07/13 16:42:39, Pam wrote: > Thanks. Mattias, will you fix the condition for sync? ...

10 years, 5 months ago (2010-07-13 16:46:04 UTC) #4

Pam (message me for reviews)

10 years, 5 months ago (2010-07-13 16:51:01 UTC) #5

On 2010/07/13 16:46:04, mnissler wrote:
> On 2010/07/13 16:42:39, Pam wrote:
> > Thanks. Mattias, will you fix the condition for sync?
> 
> I'll do so, expect the CL tomorrow.

Plenty of time -- the tree's likely to be closed until then anyway. :P

- Pam

Expand Messages | Collapse Messages