Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 298813002: views: Move MenuButton from TextButton to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable DragDirectlyToSecondWindow. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h" 5 #include "chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ash/wm/window_state.h" 9 #include "ash/wm/window_state.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 1192
1193 // browser() will have been destroyed, but browser2 should remain. 1193 // browser() will have been destroyed, but browser2 should remain.
1194 ASSERT_EQ(1u, native_browser_list->size()); 1194 ASSERT_EQ(1u, native_browser_list->size());
1195 1195
1196 EXPECT_FALSE(GetIsDragged(browser2)); 1196 EXPECT_FALSE(GetIsDragged(browser2));
1197 1197
1198 // Remaining browser window should not be maximized 1198 // Remaining browser window should not be maximized
1199 EXPECT_FALSE(browser2->window()->IsMaximized()); 1199 EXPECT_FALSE(browser2->window()->IsMaximized());
1200 } 1200 }
1201 1201
1202 #if defined(OS_CHROMEOS) || defined(OS_LINUX) 1202 #if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_WIN)
1203 // TODO(sky,sad): Disabled as it fails due to resize locks with a real 1203 // TODO(sky,sad): Disabled as it fails due to resize locks with a real
1204 // compositor. crbug.com/331924 1204 // compositor. crbug.com/331924
1205 #define MAYBE_DragDirectlyToSecondWindow DISABLED_DragDirectlyToSecondWindow 1205 #define MAYBE_DragDirectlyToSecondWindow DISABLED_DragDirectlyToSecondWindow
1206 #else 1206 #else
1207 #define MAYBE_DragDirectlyToSecondWindow DragDirectlyToSecondWindow 1207 #define MAYBE_DragDirectlyToSecondWindow DragDirectlyToSecondWindow
1208 #endif 1208 #endif
1209 // Creates two browsers, drags from first into the second in such a way that 1209 // Creates two browsers, drags from first into the second in such a way that
1210 // no detaching should happen. 1210 // no detaching should happen.
1211 IN_PROC_BROWSER_TEST_P(DetachToBrowserTabDragControllerTest, 1211 IN_PROC_BROWSER_TEST_P(DetachToBrowserTabDragControllerTest,
1212 MAYBE_DragDirectlyToSecondWindow) { 1212 MAYBE_DragDirectlyToSecondWindow) {
(...skipping 990 matching lines...) Expand 10 before | Expand all | Expand 10 after
2203 DetachToBrowserTabDragControllerTest, 2203 DetachToBrowserTabDragControllerTest,
2204 ::testing::Values("mouse", "touch")); 2204 ::testing::Values("mouse", "touch"));
2205 INSTANTIATE_TEST_CASE_P(TabDragging, 2205 INSTANTIATE_TEST_CASE_P(TabDragging,
2206 DetachToBrowserTabDragControllerTestTouch, 2206 DetachToBrowserTabDragControllerTestTouch,
2207 ::testing::Values("touch")); 2207 ::testing::Values("touch"));
2208 #elif defined(USE_ASH) 2208 #elif defined(USE_ASH)
2209 INSTANTIATE_TEST_CASE_P(TabDragging, 2209 INSTANTIATE_TEST_CASE_P(TabDragging,
2210 DetachToBrowserTabDragControllerTest, 2210 DetachToBrowserTabDragControllerTest,
2211 ::testing::Values("mouse")); 2211 ::testing::Values("mouse"));
2212 #endif 2212 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698