Always pass along the GAIA failure event, regardless of the local authenticat...

chrome/browser/sync/engine/auth_watcher.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/auth_watcher.h"
 
 #include "base/file_util.h"
 #include "base/string_util.h"
 #include "chrome/browser/sync/engine/all_status.h"
 #include "chrome/browser/sync/engine/authenticator.h"
@@ skipping 197 matching lines @@
 bool AuthWatcher::AuthenticateLocally(string email, const string& password) {
   DCHECK_EQ(MessageLoop::current(), message_loop());
   user_settings_->GetEmailForSignin(&email);
   return user_settings_->VerifyAgainstStoredHash(email, password)
     && AuthenticateLocally(email);
 }
 
 void AuthWatcher::ProcessGaiaAuthFailure() {
   DCHECK_EQ(MessageLoop::current(), message_loop());
   gaia::GaiaAuthenticator::AuthResults results = gaia_->results();
-  if (LOCALLY_AUTHENTICATED == status_) {
-    return;  // nothing todo
-  } else if (AuthenticateLocally(results.email, results.password)) {
+  if (LOCALLY_AUTHENTICATED != status_ &&
+      AuthenticateLocally(results.email, results.password)) {

[chron_chromium.org, 2010/07/13 00:32:53]

This seems fine as long as we test the conditions where this event is thrown,
and everything still works fine. 

i.e. does offline use still work ok? or does about:sync display anything weird?
My guess for anything that might go weird is if we start the browser offline,
fail a gaia attempt, does sync continue to be enabled and track changes?

It looks fine assuming this is true.

     // TODO(chron): Do we really want a bogus token?
     const string auth_token("bogus");
     user_settings_->SetAuthTokenForService(results.email,
                                            SYNC_SERVICE_NAME,
                                            auth_token);
-    const bool unavailable =
-        gaia::ConnectionUnavailable == results.auth_error ||
-        gaia::Unknown == results.auth_error ||
-        gaia::ServiceUnavailable == results.auth_error;
-    if (unavailable)
-      return;
   }
   AuthWatcherEvent myevent = { AuthWatcherEvent::GAIA_AUTH_FAILED, &results };
   NotifyListeners(&myevent);
 }
 
 void AuthWatcher::DoAuthenticate(const AuthRequest& request) {
   DCHECK_EQ(MessageLoop::current(), message_loop());
 
   AuthWatcherEvent event = { AuthWatcherEvent::AUTHENTICATION_ATTEMPT_START };
   NotifyListeners(&event);
@@ skipping 107 matching lines @@
 string AuthWatcher::email() const {
   return gaia_->email();
 }
 
 void AuthWatcher::NotifyListeners(AuthWatcherEvent* event) {
   event->trigger = current_attempt_trigger_;
   channel_->NotifyListeners(*event);
 }
 
 }  // namespace browser_sync