Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2987003: Clean up app_resources.grd:... (Closed)

Created:
10 years, 5 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Clean up app_resources.grd: * Alphabetize a couple entries * Move things to theme_resources.grd where possible; also fixes problems in chrome.gyp and theme_resources.grd that were causing "toolkit_views" to not be properly handled here, so this won't cause problems * Scope things only used by views under an appropriate conditional BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M app/resources/app_resources.grd View 7 chunks +13 lines, -41 lines 0 comments Download
D app/resources/infobarbutton_b_h.png View Binary file 0 comments Download
app/resources/infobarbutton_b_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/resources/infobarbutton_b_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_bl_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_bl_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_bl_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_br_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_br_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_br_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_c_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_c_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_c_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_l_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_l_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_l_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_menu_droparrow.png View Binary file 0 comments Download
D app/resources/infobarbutton_r_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_r_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_r_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_t_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_t_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_t_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_tl_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_tl_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_tl_p.png View Binary file 0 comments Download
D app/resources/infobarbutton_tr_h.png View Binary file 0 comments Download
D app/resources/infobarbutton_tr_n.png View Binary file 0 comments Download
D app/resources/infobarbutton_tr_p.png View Binary file 0 comments Download
app/resources/input_alert.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_b_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_b_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/infobarbutton_b_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/infobarbutton_bl_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_bl_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_bl_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_br_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_br_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_br_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/infobarbutton_c_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_c_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_c_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_l_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_l_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_l_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/infobarbutton_menu_droparrow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_r_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_r_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_r_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_t_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_t_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_t_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/infobarbutton_tl_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_tl_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_tl_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_tr_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_tr_n.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/infobarbutton_tr_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/input_alert.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 5 chunks +40 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/content_exception_editor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/browser/views/infobars/infobar_button_border.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/views/infobars/translate_infobar_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/exception_editor_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
Tony, this is identical to yesterday's http://codereview.chromium.org/2953005 except for the change in chrome.gyp and most ...
10 years, 5 months ago (2010-07-13 22:15:45 UTC) #1
tony
10 years, 5 months ago (2010-07-13 22:18:31 UTC) #2 
LGTM!

Powered by Google App Engine
This is Rietveld 408576698