Issue 2987002: Removed incorrect dcheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2987002: Removed incorrect dcheck. (Closed)

Created:
10 years, 5 months ago by erikchen

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

SPDY incorrectly DCHECKed that the SYN_REPLY headers could never be an empty list. TEST=net_unittests BUG=47991 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52264

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	net/spdy/spdy_network_transaction_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	net/spdy/spdy_stream.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

LGTM. For the checkin comment, you should try to make it so that those not ...

10 years, 5 months ago (2010-07-13 18:16:31 UTC) #2

Mike Belshe

10 years, 5 months ago (2010-07-13 18:17:10 UTC) #3

Also - checkin comments should always contain at least two fields:

BUG=XXXX
TEST=YYYY

If there is no bug or no test, use "none".



On 2010/07/13 18:16:31, Mike Belshe wrote:
> LGTM.
> 
> For the checkin comment, you should try to make it so that those not familiar
> with SPDY can understand it.
> 
> For example:
> 
> Fix case where SPDY incorrectly DCHECKed that the SYN_REPLY headers could
never
> be an empty list.

Expand Messages | Collapse Messages