Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2986002: More header cleanup: (Closed)

Created:
10 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, cbentzel+watch_chromium.org, John Grabowski, idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, Paul Godavari, jam, ncarter (slow), Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, kuchhal, darin-cc_chromium.org, tim (not reviewing), fbarchard, Alpha Left Google, Paweł Hajdan Jr., awong, scherkus (not reviewing), davemoore+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

More header cleanup: - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52336

Patch Set 1 #

Total comments: 1

Patch Set 2 : mac compile fixes maybe #

Patch Set 3 : windows + mac fixes #

Patch Set 4 : rebase due to change #

Patch Set 5 : win fixes #

Patch Set 6 : chromeos fixes #

Patch Set 7 : mac compile fixes (tested locally) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -76 lines) Patch
M app/animation_container_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M app/slide_animation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/message_loop.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M base/message_loop.cc View 4 chunks +40 lines, -39 lines 0 comments Download
M base/message_loop_proxy_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/observer_list_threadsafe.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/weak_ptr_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cancelable_request.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_thread_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/download_item_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/external_protocol_dialog.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_util.h View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gears_integration.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/geolocation/access_token_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_url_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/idle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/chrome_net_log.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile_import_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_bloom.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellcheck_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/desktop_notifications/active_notification_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_authenticator2.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/gpu_channel_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/job_status_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_process.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/filters.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/video_frame_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/ffmpeg_glue_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/video_renderer_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/capturing_net_log.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/file_stream_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/file_stream_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/host_resolver_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/listen_socket_unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_log.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/base/net_log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/server/http_listen_socket.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/server/http_server_request_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/fetch/http_listen_socket.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/fetch/http_server_request_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Moar header cleanup
10 years, 5 months ago (2010-07-12 21:16:59 UTC) #1
Evan Martin
10 years, 5 months ago (2010-07-12 21:27:34 UTC) #2 
LGTM

http://codereview.chromium.org/2986002/diff/1/3
File base/message_loop.h (left):

http://codereview.chromium.org/2986002/diff/1/3#oldcode431
base/message_loop.h:431: static bool enable_histogrammer_;
Ah!  I was gonna suggest this before but then I figured it was too much work!

Powered by Google App Engine
This is Rietveld 408576698