Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2985005: Disabling ExtensionPrefStoreTest on valgrind bot as they have memory leak. (Closed)

Created:
10 years, 5 months ago by oshima
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, Paweł Hajdan Jr.
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Disabling ExtensionPrefStoreTest on valgrind bot as they have memory leak. Please revert this once you fix this problem. TBR=pam@chromium.org BUG=48980 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/test/data/valgrind/ui_tests.gtest.txt View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
10 years, 5 months ago (2010-07-13 18:23:41 UTC) #1
stuartmorgan
The bug linked here has nowhere near enough information; please paste full leak stacks into ...
10 years, 5 months ago (2010-07-13 18:27:04 UTC) #2
Pam (message me for reviews)
Thank you both for looking into these problems. I'll work on them today. I agree: ...
10 years, 5 months ago (2010-07-14 08:38:59 UTC) #3
oshima
10 years, 5 months ago (2010-07-14 15:24:38 UTC) #4
This has already been reverted. Thank you for looking into this.

- oshima

On Wed, Jul 14, 2010 at 1:38 AM, <pam@chromium.org> wrote:

> Thank you both for looking into these problems. I'll work on them today. I
> agree: please re-enable the tests now that they're listed as suppressions.
>
> - Pam
>
>
> http://codereview.chromium.org/2985005/show
>

Powered by Google App Engine
This is Rietveld 408576698