Clean up FTP code a bit:

Clean up FTP code a bit:

- remove unneeded states
- minor style and error handling improvements

This change removes ACCT command support. It was really untested, and I think it wouldn't work in case it was needed. We may add it back when we get a good test case. However, people are unlikely to use a web browser to access servers that require usage of ACCT command.

TEST=net_unittests
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52266

[wtc, 2010-07-13 04:32:34]

LGTM.

It would be nice to explain briefly in the CL's Description
why the ACCT states aren't needed.

[eroman, 2010-07-13 22:29:49]

lgtm.

so i guess the difference here is that before when PASS failed with a 3xx it
would transition to sending "ACCT noaccount", whereas now we will fail with
ERR_FAILED ?
Seems reasonable to me, although I don't understand the compatibility impact.

[Paweł Hajdan Jr., 2010-07-14 01:27:56]

I've updated the CL description. The tree is closed, so you'll probably have an
opportunity to take another look before I manage to land it.

eroman, you're right. I'm also not usre about the compatibility impact, but I
think the old ACCT handling was broken anyway. We're unlikely to succeed by
trying to log in as "noacct".

[eroman, 2010-07-14 01:43:14]

LGTM.

Tree is open if you commit real fast right now ;)