Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2983005: Move shflags into crosutils.git (Closed)

Created:
10 years, 5 months ago by anush
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

Move shflags into crosutils.git Change-Id: I3aa6275362910addfaa25db9a1578a5496019c9e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with sosa's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1011 lines, -1 line) Patch
M common.sh View 1 1 chunk +1 line, -1 line 0 comments Download
A lib/shflags/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
A lib/shflags/shflags View 1 chunk +1009 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
anush
10 years, 5 months ago (2010-07-13 20:15:24 UTC) #1
sosa
Can you add a TEST= stanza to your issue to indicate how you tested your ...
10 years, 5 months ago (2010-07-13 21:16:57 UTC) #2
anush
10 years, 5 months ago (2010-07-13 21:47:39 UTC) #3
sosa
Still don't have the TEST= stanza in the issue (Edit issue and change the description). ...
10 years, 5 months ago (2010-07-13 21:51:03 UTC) #4
anush
10 years, 5 months ago (2010-07-13 21:53:10 UTC) #5
TEST=pull a new checkout and run ./make_chroot ./enter_chroot ./build_packages
and ./build_image for x86-generic (and building arm-generic now). 

Yes. we will install cros-utils bin/ lib/ into the /usr/ dir in the chroot. 

Thanks

On 2010/07/13 21:47:39, anush wrote:
>

Powered by Google App Engine
This is Rietveld 408576698