Issue 2982003: ChromeFrame back forward navigations at times would mess up the navigation hi...

Issue 2982003: ChromeFrame back forward navigations at times would mess up the navigation hi... (Closed)

Created:
10 years, 5 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

ChromeFrame back forward navigations at times would mess up the navigation history if the back and the current page both were rendered in ChromeFrame. This was because the back operation would incorrectly navigate twice. Once via IE history navigation and the other navigation would originate within the renderer and would execute as a new navigation in IE. Fix is to not report backforward navigations as top level navigations to the external host. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44403 Bug=44403 Test=Covered by ChromeFrame test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52235

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Total comments: 3

Patch Set 10 : '' #

Patch Set 11 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -3 lines)			Patch
M	chrome/renderer/render_view.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+4 lines, -2 lines	0 comments	Download
A	chrome_frame/test/data/action.html	View	2 3 4 5 6 7 8 9 10	1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome_frame/test/data/form-get.html	View	2 3 4 5 6 7 8 9 10	1 chunk	+33 lines, -0 lines	1 comment	Download
M	chrome_frame/test/navigation_test.cc	View	2 3 4 5 6 7 8 9 10	1 chunk	+46 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

amit

http://codereview.chromium.org/2982003/diff/1/3 File chrome_frame/chrome_active_document.cc (right): http://codereview.chromium.org/2982003/diff/1/3#newcode706 chrome_frame/chrome_active_document.cc:706: new_navigation_info.navigation_type == NavigationType::EXISTING_PAGE) { How do we avoid getting ...

10 years, 5 months ago (2010-07-13 17:26:30 UTC) #2

amit

http://codereview.chromium.org/2982003/diff/24001/5004 File chrome_frame/test/data/action.html (right): http://codereview.chromium.org/2982003/diff/24001/5004#newcode1 chrome_frame/test/data/action.html:1: <html> Please indent as per other test pages http://codereview.chromium.org/2982003/diff/24001/5005 ...

10 years, 5 months ago (2010-07-13 18:48:40 UTC) #3

amit

10 years, 5 months ago (2010-07-13 19:00:34 UTC) #4

lgtm and thanks for resurrecting the test.
We still need to worry about navigator.back/fwd but that's broken today anyway.

http://codereview.chromium.org/2982003/diff/30001/31003
File chrome_frame/test/data/form-get.html (right):

http://codereview.chromium.org/2982003/diff/30001/31003#newcode27
chrome_frame/test/data/form-get.html:27: <input id="100" name="submit"
type="submit" value="Submit">
nit: id can be a descriptive name like submit_button

Expand Messages | Collapse Messages