Chromium Code Reviews

Issue 2982001: Simplifying GenerateDictionaryNegativeLookup by making the 'extra' parameter ... (Closed)

Created:
10 years, 5 months ago by SeRya
Modified:
9 years, 7 months ago
Reviewers:
Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Simplifying GenerateDictionaryNegativeLookup by making the 'extra' parameter mandatory. Committed: http://code.google.com/p/v8/source/detail?r=5049

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+219 lines, -214 lines)
M src/arm/stub-cache-arm.cc View 47 chunks +82 lines, -87 lines 0 comments
M src/ia32/stub-cache-ia32.cc View 46 chunks +62 lines, -59 lines 0 comments
M src/stub-cache.h View 5 chunks +12 lines, -8 lines 0 comments
M src/x64/stub-cache-x64.cc View 45 chunks +63 lines, -60 lines 0 comments

Messages

Total messages: 3 (0 generated)
SeRya
10 years, 5 months ago (2010-07-12 17:11:16 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/2982001/diff/17001/18001 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/2982001/diff/17001/18001#newcode95 src/arm/stub-cache-arm.cc:95: Register r0, Since this is ARM I find ...
10 years, 5 months ago (2010-07-12 17:19:32 UTC) #2
SeRya
10 years, 5 months ago (2010-07-13 10:02:35 UTC) #3 
http://codereview.chromium.org/2982001/diff/17001/18001
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/2982001/diff/17001/18001#newcode95
src/arm/stub-cache-arm.cc:95: Register r0,
On 2010/07/12 17:19:32, Mads Ager wrote:
> Since this is ARM I find the r0 and r1 names confusing (since they are names
of
> real registers). If they are scratch registers could you use scratch0 and
> scratch1 or something like that? Or give them other telling names?

Done.

Powered by Google App Engine