Issue 2981007: Rename UpdateCheckAction|Params to OmahaRequestAction|Params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2981007: Rename UpdateCheckAction|Params to OmahaRequestAction|Params. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Rename UpdateCheckAction|Params to OmahaRequestAction|Params. Also, renamed UpdateCheckResponse to OmahaResponse. BUG=560 TEST=unit tests, gmerge'd on device.

Patch Set 1 #

Patch Set 2 : fix trailing whitespace. #

Patch Set 3 : fix the comment #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+648 lines, -648 lines)			Patch
M	SConstruct	View		4 chunks	+2 lines, -2 lines	0 comments	Download
M	integration_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	omaha_request_action.h	View	1 2	8 chunks	+37 lines, -37 lines	0 comments	Download
A +	omaha_request_action.cc	View		7 chunks	+30 lines, -30 lines	0 comments	Download
A	omaha_request_action_unittest.cc	View		1 chunk	+538 lines, -0 lines	0 comments	Download
M	omaha_request_prep_action.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	omaha_request_prep_action.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	omaha_request_prep_action_unittest.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	omaha_response_handler_action.h	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	omaha_response_handler_action.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	omaha_response_handler_action_unittest.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	update_attempter.cc	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
D	update_check_action_unittest.cc	View		1 chunk	+0 lines, -538 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 5 months ago (2010-07-13 21:12:10 UTC) #2

LGTM

To test, I always do:

./gen_coverage...
emerge-x86-generic -av1 update_engine
emerge-arm-generic -av1 update_engine

I think it you make sure it compiles on the host and on a target that should
generally be good enough. Looks like you did that.

Expand Messages | Collapse Messages