Issue 2981005: Prepare push to trunk. Now working on version 2.3.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2981005: Prepare push to trunk. Now working on version 2.3.0. (Closed)

Created:
10 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.3.0. Committed: http://code.google.com/p/v8/source/detail?r=5058

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	ChangeLog	View		2 chunks	+14 lines, -0 lines	2 comments	Download
	M	src/version.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

10 years, 5 months ago (2010-07-13 19:43:08 UTC) #2

LGTM

http://codereview.chromium.org/2981005/diff/1/2
File ChangeLog (right):

http://codereview.chromium.org/2981005/diff/1/2#newcode5
ChangeLog:5: Fixed crash bug when preparsing from non-external V8 string (issue
775).
from -> a?

http://codereview.chromium.org/2981005/diff/1/2#newcode7
ChangeLog:7: Fixed JSON.parse bug causing input not to be converted to string
(issue 764).
Long line

Expand Messages | Collapse Messages