Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2978007: Mark KeygenHandlerTest.ConcurrencyTest no longer flakey. (Closed)

Created:
10 years, 5 months ago by davidben
Modified:
9 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mark KeygenHandlerTest.ConcurrencyTest no longer flakey. r51734 added the relevant locks. BUG=48006 TEST=KeygenHandlerTest.ConcurrencyTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M net/base/keygen_handler_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidben
It doesn't look like the tests have failed again since the locks were added about ...
10 years, 5 months ago (2010-07-14 02:57:46 UTC) #1
Erik does not do reviews
10 years, 5 months ago (2010-07-14 15:48:38 UTC) #2
LGTM

On Tue, Jul 13, 2010 at 7:57 PM, <davidben@chromium.org> wrote:

> Reviewers: Erik Kay,
>
> Message:
> It doesn't look like the tests have failed again since the locks were added
> about a week ago.
>
> Description:
> Mark KeygenHandlerTest.ConcurrencyTest no longer flakey.
>
> r51734 added the relevant locks.
>
> BUG=48006
> TEST=KeygenHandlerTest.ConcurrencyTest
>
> Please review this at http://codereview.chromium.org/2978007/show
>
> Affected files:
>  M net/base/keygen_handler_unittest.cc
>
>
> Index: net/base/keygen_handler_unittest.cc
> diff --git a/net/base/keygen_handler_unittest.cc
> b/net/base/keygen_handler_unittest.cc
> index
>
6d9d2d1f8e7862c1e808c9fa161dbc1bc3f67bb1..15ec0ce7eeb18549b44735463cc7b3b8e01740d4
> 100644
> --- a/net/base/keygen_handler_unittest.cc
> +++ b/net/base/keygen_handler_unittest.cc
> @@ -112,16 +112,9 @@ class ConcurrencyTestTask : public Task {
>   std::string* result_;
>  };
>
> -// See crbug.com/48006
> -#if defined(OS_MACOSX)
> -#define MAYBE_ConcurrencyTest FLAKY_ConcurrencyTest
> -#else
> -#define MAYBE_ConcurrencyTest ConcurrencyTest
> -#endif
> -
>  // We asynchronously generate the keys so as not to hang up the IO thread.
> This
>  // test tries to catch concurrency problems in the keygen implementation.
> -TEST_F(KeygenHandlerTest, MAYBE_ConcurrencyTest) {
> +TEST_F(KeygenHandlerTest, ConcurrencyTest) {
>   const int NUM_HANDLERS = 5;
>   base::WaitableEvent* events[NUM_HANDLERS] = { NULL };
>   std::string results[NUM_HANDLERS];
>
>
>

Powered by Google App Engine
This is Rietveld 408576698