chrome/browser/sync/sync_setup_flow.cc - Issue 2976003: Coverity: missing break in SyncSetupFlow::OnDialogClosed switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_setup_flow.cc

Issue 2976003: Coverity: missing break in SyncSetupFlow::OnDialogClosed switch. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/sync_setup_flow.cc

diff --git a/chrome/browser/sync/sync_setup_flow.cc b/chrome/browser/sync/sync_setup_flow.cc

index 84cbf111e995769608910cb9ecc2887ef3fb0859..769d4b0b2f03fa6246d6e4c12b1a384de3645543 100644

--- a/chrome/browser/sync/sync_setup_flow.cc

+++ b/chrome/browser/sync/sync_setup_flow.cc

@@ -299,6 +299,7 @@ void SyncSetupFlow::OnDialogClosed(const std::string& json_retval) {

case SyncSetupWizard::CHOOSE_DATA_TYPES:

ProfileSyncService::SyncEvent(

ProfileSyncService::CANCEL_FROM_CHOOSE_DATA_TYPES);

+ break;

case SyncSetupWizard::DONE_FIRST_TIME:

case SyncSetupWizard::DONE:

// TODO(sync): rename this histogram; it's tracking authorization AND

« no previous file with comments | « no previous file | no next file » | no next file with comments »