Issue 2976003: Coverity: missing break in SyncSetupFlow::OnDialogClosed switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2976003: Coverity: missing break in SyncSetupFlow::OnDialogClosed switch. (Closed)

Created:
10 years, 5 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Dan Tasse, ncarter (slow), tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Coverity: missing break in SyncSetupFlow::OnDialogClosed switch. This may have lead to some bad stats in Sync.UserPerceivedAuthorizationTime histogram. CID=11400 TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52403

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/sync/sync_setup_flow.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages