Issue 2975006: Fix duplicate sever-port bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2975006: Fix duplicate sever-port bug (Closed)

Created:
10 years, 5 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler, sleffler

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Fix duplicate sever-port bug cros_copy_upgrade_server had a bug where it would always start servers on port 8081 regrdless of whether that port was free. This was a bug in the "get next free port" code. BUG=chromium-os:4776 TEST=Reran multiple instances at once, run netstat -nlt

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bin/cros_copy_upgrade_server.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages