Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2975005: Disable power-save/screensaver in X for factory (Closed)

Created:
10 years, 5 months ago by tbroch1
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://git@chromiumos-git/autotest.git
Visibility:
Public.

Description

Disable power-save/screensaver in X for factory BUG=chrome-os-partner id:385 TEST=on DUT w/ B824

Patch Set 1 #

Total comments: 2

Patch Set 2 : print entire xset command for readability #

Total comments: 2

Patch Set 3 : fix that actually works for me. Previous attempt didnt work #

Patch Set 4 : tammo's input on inlining X call to remove need for separate xstart.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M client/deps/factory/startx.sh View 3 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nick Sanders
lgtm w/ comment http://codereview.chromium.org/2975005/diff/1/2 File client/site_tests/suite_Factory/control (right): http://codereview.chromium.org/2975005/diff/1/2#newcode217 client/site_tests/suite_Factory/control:217: factory.log("cfg_factory_x: cmd = %s" % cmd) ...
10 years, 5 months ago (2010-07-13 04:49:38 UTC) #1
Tammo Spalink
Have you verified that this works? I am asking because I initially wanted to move ...
10 years, 5 months ago (2010-07-13 18:03:22 UTC) #2
Tammo Spalink
http://codereview.chromium.org/2975005/diff/4001/5001 File client/site_tests/suite_Factory/control (right): http://codereview.chromium.org/2975005/diff/4001/5001#newcode212 client/site_tests/suite_Factory/control:212: os.environ.setdefault('DISPLAY', ':0') this should already be set, by the ...
10 years, 5 months ago (2010-07-13 18:05:43 UTC) #3
Sameer Nanda
http://codereview.chromium.org/2975005/diff/1/2 File client/site_tests/suite_Factory/control (right): http://codereview.chromium.org/2975005/diff/1/2#newcode217 client/site_tests/suite_Factory/control:217: factory.log("cfg_factory_x: cmd = %s" % cmd) drive by comments: ...
10 years, 5 months ago (2010-07-13 18:07:16 UTC) #4
Tammo Spalink
LGTM -- provided you go with the one line solution, which is verified to also ...
10 years, 5 months ago (2010-07-16 01:14:28 UTC) #5
Tammo Spalink
10 years, 5 months ago (2010-07-16 01:15:04 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698