Chromium Code Reviews

Unified Diff: chrome/browser/cocoa/bookmark_bar_controller.mm

Issue 2973004: [Mac]Implement ViewID support. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Turns out that, it's not a good solution. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « chrome/browser/cocoa/base_view_unittest.mm ('k') | chrome/browser/cocoa/bookmark_bar_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bar_controller.mm
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.mm b/chrome/browser/cocoa/bookmark_bar_controller.mm
index b918707983e76c47b567224eb6f593d54860c39f..88e4b21b313f47b27a3d6378978a4872fa9446f0 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller.mm
+++ b/chrome/browser/cocoa/bookmark_bar_controller.mm
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -33,6 +33,7 @@
#import "chrome/browser/cocoa/menu_button.h"
#import "chrome/browser/cocoa/themed_window.h"
#import "chrome/browser/cocoa/toolbar_controller.h"
+#import "chrome/browser/cocoa/view_id_util.h"
#import "chrome/browser/cocoa/view_resizer.h"
#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/pref_service.h"
@@ -997,6 +998,7 @@ const NSTimeInterval kBookmarkBarAnimationDuration = 0.12;
scoped_nsobject<BookmarkButton>
button([[BookmarkButton alloc] initWithFrame:frame]);
DCHECK(button.get());
+ [button setViewID:VIEW_ID_BOOKMARK_BAR_ELEMENT];
// [NSButton setCell:] warns to NOT use setCell: other than in the
// initializer of a control. However, we are using a basic
@@ -1072,6 +1074,7 @@ const NSTimeInterval kBookmarkBarAnimationDuration = 0.12;
BookmarkButton* button = [[BookmarkButton alloc] initWithFrame:frame];
[button setDraggable:NO];
otherBookmarksButton_.reset(button);
+ [button setViewID:VIEW_ID_OTHER_BOOKMARKS];
// Make sure this button, like all other BookmarkButtons, lives
// until the end of the current event loop.
« no previous file with comments | « chrome/browser/cocoa/base_view_unittest.mm ('k') | chrome/browser/cocoa/bookmark_bar_view.mm » ('j') | no next file with comments »

Powered by Google App Engine