Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/cocoa/view_id_util_browsertest.cc

Issue 2973004: [Mac]Implement ViewID support. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Turns out that, it's not a good solution. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/logging.h"
6 #include "base/utf_string_conversions.h"
7 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "chrome/browser/browser.h"
9 #include "chrome/browser/browser_window.h"
10 #include "chrome/browser/cocoa/view_id_util.h"
11 #include "chrome/browser/download/download_shelf.h"
12 #include "chrome/browser/pref_service.h"
13 #include "chrome/common/pref_names.h"
14 #include "chrome/common/url_constants.h"
15 #include "chrome/test/in_process_browser_test.h"
16 #include "chrome/test/ui_test_utils.h"
17
18 // Basic sanity check of ViewID use on the mac.
19 class ViewIDTest : public InProcessBrowserTest {
20 public:
21 ViewIDTest() : root_window_(nil) {}
22
23 void CheckViewID(ViewID view_id, bool should_have) {
24 if (!root_window_)
25 root_window_ = browser()->window()->GetNativeHandle();
26
27 ASSERT_TRUE(root_window_);
28 NSView* view = view_id_util::GetView(root_window_, view_id);
29 EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id;
30 }
31
32 private:
33 NSWindow* root_window_;
34 };
35
36 IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) {
37 // Make sure FindBar is created to test
38 // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE.
39 browser()->ShowFindBar();
40
41 // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
42 browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsOpenDocked,
43 true);
44 browser()->ToggleDevToolsWindow(false);
45
46 // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
47 browser()->window()->GetDownloadShelf()->Show();
48
49 // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
50 BookmarkModel* bookmark_model = browser()->profile()->GetBookmarkModel();
51 if (bookmark_model) {
52 if (!bookmark_model->IsLoaded())
53 ui_test_utils::WaitForBookmarkModelToLoad(bookmark_model);
54
55 bookmark_model->SetURLStarred(GURL(chrome::kAboutBlankURL),
56 UTF8ToUTF16("about"), true);
57 }
58
59 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
60 // Extension shelf is being removed, http://crbug.com/30178.
61 if (i == VIEW_ID_DEV_EXTENSION_SHELF)
62 continue;
63
64 // Mac implementation does not support following ids yet.
65 if (i == VIEW_ID_STAR_BUTTON ||
66 i == VIEW_ID_PAGE_MENU ||
67 i == VIEW_ID_AUTOCOMPLETE ||
68 i == VIEW_ID_CONTENTS_SPLIT ||
69 i == VIEW_ID_INFO_BAR_CONTAINER) {
70 continue;
71 }
72
73 CheckViewID(static_cast<ViewID>(i), true);
74 }
75
76 CheckViewID(VIEW_ID_TAB_STRIP, true);
77 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
78 }
79
80 IN_PROC_BROWSER_TEST_F(ViewIDTest, Tab) {
81 CheckViewID(VIEW_ID_TAB_0, true);
82 CheckViewID(VIEW_ID_TAB_1, false);
83
84 browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),
85 NEW_BACKGROUND_TAB, PageTransition::TYPED);
86
87 CheckViewID(VIEW_ID_TAB_0, true);
88 CheckViewID(VIEW_ID_TAB_1, true);
89 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/view_id_util.mm ('k') | chrome/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698