Issue 2971: Merge http://v8.googlecode.com/svn/branches/bleeding_edge/tools/v8.xcodeproj@...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2971: Merge http://v8.googlecode.com/svn/branches/bleeding_edge/tools/v8.xcodeproj@... (Closed)

Created:
12 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Merge http://v8.googlecode.com/svn/branches/bleeding_edge/tools/v8.xcodeproj@319 to our copy (includes changes from r300 too). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2375

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+324 lines, --1 lines)			Patch
	M	build/v8.xcodeproj/project.pbxproj	View		19 chunks	+325 lines, -0 lines	0 comments	Download
	A +	build/v8.xcodeproj/v8-arm_prebuild.sh	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

TBR because it fixes our broken build. This is a pretty straightforward merge. I removed ...

12 years, 3 months ago (2008-09-18 19:32:46 UTC) #1

iposva

12 years, 3 months ago (2008-09-18 20:12:30 UTC) #2

What I find confusing and would like to change before taking this into the
original V8 repository is that we apparently end up with two v8*_prebuild.sh
files which are identical.

Maybe we can make this build step part of its own target shared between the
regular and the ARM simulator builds. At which point you do only have a single
target name.

I do like the fact that the script is external because then it is not just one
long line...

-Ivan

Expand Messages | Collapse Messages