Updated cache-invalidation-api to @33.

Updated cache-invalidation-api to @33.

BUG=34647
TEST=built on all platforms

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52018

[akalin, 2010-07-09 18:57:04]

+nick, +ghc for review.

Will check in only after Windows trybot passes (or a local Windows build
succeeds).

[ncarter (slow), 2010-07-09 18:58:18]

Rubber stamp.

On Fri, Jul 9, 2010 at 11:57 AM, <akalin@chromium.org> wrote:

> Reviewers: ncarter, ghc,
>
> Message:
> +nick, +ghc for review.
>
> Will check in only after Windows trybot passes (or a local Windows build
> succeeds).
>
> Description:
> Updated cache-invalidation-api to @33.
>
> BUG=34647
> TEST=built on all platforms
>
> Please review this at http://codereview.chromium.org/2970001/show
>
> Affected files:
>  M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
>
1a398cc90eeb95f5e578fcbb1659006158055f02..100d815eb69f27e868fa17732561321a1fa73d0a
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -46,7 +46,7 @@ deps = {
>     "http://protobuf.googlecode.com/svn/trunk@327",
>
>   "src/third_party/cacheinvalidation/files":
> -    "http://google-cache-invalidation-api.googlecode.com/svn/trunk@30",
> +    "http://google-cache-invalidation-api.googlecode.com/svn/trunk@33",
>
>   "src/tools/gyp":
>     "http://gyp.googlecode.com/svn/trunk@836",
>
>
>

[akalin, 2010-07-09 20:21:30]

One more rubber stamp please!  Had to fix some gyp files and compile errors.

On 2010/07/09 18:58:18, ncarter wrote:
> Rubber stamp.
> 
> On Fri, Jul 9, 2010 at 11:57 AM, <mailto:akalin@chromium.org> wrote:
> 
> > Reviewers: ncarter, ghc,
> >
> > Message:
> > +nick, +ghc for review.
> >
> > Will check in only after Windows trybot passes (or a local Windows build
> > succeeds).
> >
> > Description:
> > Updated cache-invalidation-api to @33.
> >
> > BUG=34647
> > TEST=built on all platforms
> >
> > Please review this at http://codereview.chromium.org/2970001/show
> >
> > Affected files:
> >  M DEPS
> >
> >
> > Index: DEPS
> > diff --git a/DEPS b/DEPS
> > index
> >
>
1a398cc90eeb95f5e578fcbb1659006158055f02..100d815eb69f27e868fa17732561321a1fa73d0a
> > 100644
> > --- a/DEPS
> > +++ b/DEPS
> > @@ -46,7 +46,7 @@ deps = {
> >     "http://protobuf.googlecode.com/svn/trunk@327",
> >
> >   "src/third_party/cacheinvalidation/files":
> > -    "http://google-cache-invalidation-api.googlecode.com/svn/trunk@30",
> > +    "http://google-cache-invalidation-api.googlecode.com/svn/trunk@33",
> >
> >   "src/tools/gyp":
> >     "http://gyp.googlecode.com/svn/trunk@836",
> >
> >
> >
>

[ghc, 2010-07-09 21:59:40]

http://codereview.chromium.org/2970001/diff/6001/7002
File chrome/browser/sync/notifier/invalidation_util.cc (right):

http://codereview.chromium.org/2970001/diff/6001/7002#newcode64
chrome/browser/sync/notifier/invalidation_util.cc:64: for (int i = 0; i <
component_stamp_log.stamp_size(); ++i) {
It's probably not necessary to print these out at all...  The component stamp
log is really intended for internal monitoring, as it just indicates when the
invalidation flowed through various server-side components.

[ncarter (slow), 2010-07-12 20:45:43]

LGTM