Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2968012: [Mac] Line up omnibox field icons and text with popup. (Closed)

Created:
10 years, 5 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

[Mac] Line up omnibox field icons and text with popup. BUG=49123 TEST=Start autocompleting something, check that things line up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Hess - ex-Googler
Constants chosen using Pixie.app. Very scalable.
10 years, 5 months ago (2010-07-14 23:59:02 UTC) #1
Scott Hess - ex-Googler
Redirecting at John so that I can save Rohit for changes he's most relevant to ...
10 years, 5 months ago (2010-07-15 00:34:27 UTC) #2
John Grabowski
10 years, 5 months ago (2010-07-15 00:41:06 UTC) #3
LGTM

Polish good.
Ugly bad.

Powered by Google App Engine
This is Rietveld 408576698