gclient.py - Issue 2968005: Add testing for the From(File()) case, fix revinfo. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(266)

My Issues | Starred Open | Closed | All

Unified Diff: gclient.py

Issue 2968005: Add testing for the From(File()) case, fix revinfo. (Closed)

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | tests/fake_repos.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index f2d9415b2b7b9618635a5db594d0d7d075b50621..8791d5300dfdf59dd445ed73b2da8ffa3f047d8b 100644

--- a/gclient.py

+++ b/gclient.py

@@ -750,6 +750,9 @@ solutions = [

if type(deps[d]) == str:

(url, rev) = GetURLAndRev(d, deps[d])

entries[d] = "%s@%s" % (url, rev)

+ elif isinstance(deps[d], self.FileImpl):

+ (url, rev) = GetURLAndRev(d, deps[d].file_location)

tony 2010/07/12 17:26:59 Nit: parens on the left are not needed (although I

M-A Ruel 2010/07/12 17:29:49 All this code will be deleted anyway.

+ entries[d] = "%s@%s" % (url, rev)

# Second pass for inherited deps (via the From keyword)

for d in deps_to_process:

« no previous file with comments | « no previous file | tests/fake_repos.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698