Issue 2968005: Add testing for the From(File()) case, fix revinfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2968005: Add testing for the From(File()) case, fix revinfo. (Closed)

Created:
10 years, 5 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Add testing for the From(File()) case, fix revinfo. This case covers the webkit gclient usage. TEST=improved smoke test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52092

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -13 lines)			Patch
M	gclient.py	View	1 chunk	+3 lines, -0 lines	2 comments	Download
M	tests/fake_repos.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	tests/gclient_smoketest.py	View	12 chunks	+20 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

Thanks for fixing. LGTM. http://codereview.chromium.org/2968005/diff/1/2 File gclient.py (right): http://codereview.chromium.org/2968005/diff/1/2#newcode754 gclient.py:754: (url, rev) = GetURLAndRev(d, deps[d].file_location) ...

10 years, 5 months ago (2010-07-12 17:26:59 UTC) #2

M-A Ruel

10 years, 5 months ago (2010-07-12 17:29:49 UTC) #3

http://codereview.chromium.org/2968005/diff/1/2
File gclient.py (right):

http://codereview.chromium.org/2968005/diff/1/2#newcode754
gclient.py:754: (url, rev) = GetURLAndRev(d, deps[d].file_location)
On 2010/07/12 17:26:59, tony wrote:
> Nit: parens on the left are not needed (although I guess it's ok to keep them
if
> you want to match the block above).

All this code will be deleted anyway.

Expand Messages | Collapse Messages