Resize stateful partition flag

Resize stateful partition flag
Added flag to resize stateful partition that we put onto the VM image.

[zel, 2010-07-14 16:20:00]

lgtm

[sosa, 2010-07-14 17:22:50]

nits and question

http://codereview.chromium.org/2964011/diff/1/2
File image_to_vm.sh (right):

http://codereview.chromium.org/2964011/diff/1/2#newcode144
image_to_vm.sh:144: # of the specified size.
Can you add a TODO to merge this code with simliar code in build_image into
common.sh?

http://codereview.chromium.org/2964011/diff/1/2#newcode145
image_to_vm.sh:145: if [ "${FLAGS_statefulfs_size}" -ne -1 ]; then
Why would you ever not want a stateful partition?  The system is fairly unusable
without a stateful partition.  Why not default this to something small like
128MB and not have a -1 option

http://codereview.chromium.org/2964011/diff/1/2#newcode152
image_to_vm.sh:152: echo "Resizing stateful partition to
${FLAGS_statefulfs_size}mb"
MB not mb

http://codereview.chromium.org/2964011/diff/1/2#newcode154
image_to_vm.sh:154: if [ -z "${STATEFUL_LOOP_DEV}" ] ; then
not space before ;

http://codereview.chromium.org/2964011/diff/1/2#newcode161
image_to_vm.sh:161: # Resize the partition
Periods at the end of all comments.

[rkc1, 2010-07-14 18:50:04]

http://codereview.chromium.org/2964011/diff/1/2
File image_to_vm.sh (right):

http://codereview.chromium.org/2964011/diff/1/2#newcode144
image_to_vm.sh:144: # of the specified size.
On 2010/07/14 17:22:51, sosa wrote:
> Can you add a TODO to merge this code with simliar code in build_image into
> common.sh?

I thought about it for a while but I realized that the steps we take to resize
are pretty different from what we take to create the image.

Though, creating the OEM image, stateful partition and rootfs in build_image are
pretty similar and should be merged into one function in common.sh

http://codereview.chromium.org/2964011/diff/1/2#newcode145
image_to_vm.sh:145: if [ "${FLAGS_statefulfs_size}" -ne -1 ]; then
On 2010/07/14 17:22:51, sosa wrote:
> Why would you ever not want a stateful partition?  The system is fairly
unusable
> without a stateful partition.  Why not default this to something small like
> 128MB and not have a -1 option

This only means that the user did not specify a stateful partition size flag, so
leave the stateful partition as is - $TEMP_STATE already points to the stateful
partition that was created in build_image, so this just ensures that in the case
the user didn't specify a flag, we just leave the original partition alone.

http://codereview.chromium.org/2964011/diff/1/2#newcode152
image_to_vm.sh:152: echo "Resizing stateful partition to
${FLAGS_statefulfs_size}mb"
On 2010/07/14 17:22:51, sosa wrote:
> MB not mb

Done.

http://codereview.chromium.org/2964011/diff/1/2#newcode154
image_to_vm.sh:154: if [ -z "${STATEFUL_LOOP_DEV}" ] ; then
On 2010/07/14 17:22:51, sosa wrote:
> not space before ;

Done.

http://codereview.chromium.org/2964011/diff/1/2#newcode161
image_to_vm.sh:161: # Resize the partition
On 2010/07/14 17:22:51, sosa wrote:
> Periods at the end of all comments.

Done.

[sosa, 2010-07-14 18:52:10]

LGTM, thanks for addressing my comments even though I swooped in after Zel's
review :)