Issue 2964: Use libevent, second try. Changes this time:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2964: Use libevent, second try. Changes this time:... (Closed)

Created:
12 years, 3 months ago by also_not_the_right_dank

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use libevent, second try. Changes this time: - remove bogus include of base/completion_callback.h - add DEPS rules to allow including third_party/libevent Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2371

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+658 lines, -20 lines)			Patch
M	base/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/SConscript	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	base/message_loop.h	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	base/message_loop.cc	View	3 chunks	+21 lines, -1 line	0 comments	Download
	base/message_pump_libevent.h	View	1 chunk	+89 lines, -0 lines	0 comments	Download
	base/message_pump_libevent.cc	View	1 chunk	+179 lines, -0 lines	0 comments	Download
M	build/SConscript.main	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/SConscript	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/SConscript	View	4 chunks	+3 lines, -1 line	0 comments	Download
M	net/base/tcp_client_socket.h	View	4 chunks	+53 lines, -18 lines	0 comments	Download
	net/base/tcp_client_socket_libevent.cc	View	1 chunk	+288 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sgk

12 years, 3 months ago (2008-09-18 23:49:58 UTC) #1

Looks like you're only building libevent for OS_POSIX, but you added 'event' to
the list of LIBS that all platforms try to link with, so the SCons build on
Windows broke.  If this is a non-Windows lib, then you need to adjust the LIBS
setting.

Expand Messages | Collapse Messages