cros_workon: introduce --all flag

cros_workon: introduce --all flag

* Replaced listall with list --all
* stop/start without arguments will now fail
* stop/start with --all will do just the expected thing
* Rewritten package list decision logic

TBR: msb - already got LGTM, then fixed a comment i noticed

[Mandeep Singh Baines, 2010-07-14 21:59:28]

LGTM

zbehan@chromium.org (zbehan@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines, anush, sosa, brian d,
>
> Description:
> cros_workon: introduce --all flag
>
> * Replaced listall with list --all
> * stop/start without arguments will now fail
> * stop/start with --all will do just the expected thing
> * Rewritten package list decision logic
>
> Please review this at http://codereview.chromium.org/2963011/show
>
> SVN Base: ssh://gitrw.chromium.org/crosutils
>
> Affected files:
>   M cros_workon
>
>
> Index: cros_workon
> diff --git a/cros_workon b/cros_workon
> index  
>
4ff535c0cbb3748b084fe8cb82bf85eb2d149820..700bf9832f6cb14b132130a67cea975dcd34846c

> 100755
> --- a/cros_workon
> +++ b/cros_workon
> @@ -24,6 +24,8 @@ DEFINE_boolean host "${FLAGS_FALSE}" \
>    "Uses the host instead of board"
>  DEFINE_string command "git status" \
>    "The command to be run by forall."
> +DEFINE_boolean all "${FLAGS_FALSE}" \
> +  "Apply to all possible packages for the given command"
>
>  FLAGS_HELP="usage: $0 <command> [flags]
>  commands:
> @@ -105,15 +107,6 @@ show_live_ebuilds () {
>    cat "${KEYWORDS_FILE}"
>  }
>
> -ATOM_LIST=$@
> -if [ -z "${ATOM_LIST}" ]; then
> -  ATOM_LIST=$(show_live_ebuilds)
> -else
> -  if ! ATOM_LIST=$(canonicalize_names "${ATOM_LIST}"); then
> -    die "Error parsing package list"
> -  fi
> -fi
> -
>  # Move a stable ebuild to the live development catgeory.  The ebuild
>  # src_unpack step fetches the package source for local development.
>  ebuild_to_live () {
> @@ -174,11 +167,37 @@ show_workon_ebuilds() {
>    done
>  }
>
> +# --all makes commands operate on different lists
> +if [ ${FLAGS_all} = "${FLAGS_TRUE}" ]; then
> +  case ${WORKON_CMD} in
> +    start) ATOM_LIST=$(show_workon_ebuilds);;
> +    stop) ATOM_LIST=$(show_live_ebuilds);;
> +    list) ;;
> +    *) die "--all is invalid for the given command";;
> +  esac
> +else # not selected --all
> +  ATOM_LIST=$@
> +  case ${WORKON_CMD} in
> +    start|stop)
> +      if [ -z "${ATOM_LIST}" ]; then
> +        die "${WORKON_CMD}: No packages specified"
> +      elif ! ATOM_LIST=$(canonicalize_names "${ATOM_LIST}"); then
> +        die "Error parsing package list"
> +      fi;;
> +    forall)
> +      if [ -z "${ATOM_LIST}" ]; then
> +        ATOM_LIST=$(show_workon_ebuilds)
> +      elif ! ATOM_LIST=$(canonicalize_names "${ATOM_LIST}"); then
> +        die "Error parsing package list"
> +      fi;;
> +    *) ;;
> +  esac
> +fi
> +
>  case ${WORKON_CMD} in
>    start)  ebuild_to_live "${ATOM_LIST}" ;;
>    stop)   ebuild_to_stable "${ATOM_LIST}" ;;
> -  list)   show_live_ebuilds ;;
> +  list)   [ ${FLAGS_all} = "${FLAGS_FALSE}" ] && show_live_ebuilds ||  
> show_workon_ebuilds ;;
>    forall) ebuild_forall "${ATOM_LIST}" ;;
> -  listall)show_workon_ebuilds ;;
>    *)      die "invalid cros_workon command" ;;
>  esac
>
>

[Mandeep Singh Baines, 2010-07-14 22:48:17]

Ah. I missed the documentation.

LGTM

[zbehan, 2010-07-14 23:02:42]

I pushed it as TBR, but the push has been hanging for like 30 minutes now
because of git being slow. I wonder how many things will it break if i
interrupt the commit. :P

On Wed, Jul 14, 2010 at 3:48 PM, <msb@chromium.org> wrote:

> Ah. I missed the documentation.
>
> LGTM
>
>
> http://codereview.chromium.org/2963011/show
>