Remove the cookie prompt from the settings UI and migrate prefs from ask to block.

Remove the cookie prompt from the settings UI and migrate prefs from ask to block.

BUG=48941
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52291

[jochen (gone - plz use gerrit), 2010-07-13 09:56:57]

please review.

this change only removes the pref UI.

Darin, should I remove the whole cookie prompt infrastructure e.g. the async
cookie policy, the nested message loop in the renderer etc, or are we likely to
need that for something else?

[darin (slow to review), 2010-07-13 16:23:29]

LGTM

I would like to remove all of the supporting infrastructure for cookie
prompting, but I had once told Amit that it might be useful for solving some of
Chrome Frame's issues related to the host network stack integration.

[amit, 2010-07-13 17:46:08]

On Tue, Jul 13, 2010 at 9:23 AM, <darin@chromium.org> wrote:

> LGTM
>
> I would like to remove all of the supporting infrastructure for cookie
> prompting, but I had once told Amit that it might be useful for solving
> some of
> Chrome Frame's issues related to the host network stack integration.

True, async cookie requests is a big deal for Chrome Frame since it needs to
fetch the cookies from the host browser.
The dependency is not obvious since it goes through an override for request
context (AutomationURLRequestContext and AutomationCookiePolicy).
https://cs.corp.google.com/p#chrome/trunk/src/chrome/browser/automation/autom...
This is sent to the host browser
via AutomationResourceMessageFilter::GetCookiesForUrl -
https://cs.corp.google.com/p?#chrome/trunk/src/chrome/browser/automation/auto...



>
> http://codereview.chromium.org/2963006/show
>

[Peter Kasting, 2010-07-13 18:36:09]

LGTM

http://codereview.chromium.org/2963006/diff/1/14
File chrome/browser/host_content_settings_map.cc (right):

http://codereview.chromium.org/2963006/diff/1/14#newcode572
chrome/browser/host_content_settings_map.cc:572: // Disable the cookie prompt
mode.
Nit: "Migrate obsolete cookie prompt mode"?