Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1897)

Unified Diff: remoting/host/encoder.h

Issue 2963003: Changing UpdateStreamPacket protobuf definition for chromoting (Closed)
Patch Set: fixed comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/client_connection_unittest.cc ('k') | remoting/host/encoder_verbatim.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/encoder.h
diff --git a/remoting/host/encoder.h b/remoting/host/encoder.h
index 09cbdde54365b47493b72197296e55ad766272c0..ee43c94ebf064d593f14f9b1f430503a653c1a0c 100644
--- a/remoting/host/encoder.h
+++ b/remoting/host/encoder.h
@@ -17,6 +17,8 @@ namespace media {
namespace remoting {
+class HostMessage;
+
// A class to perform the task of encoding a continous stream of
// images.
// This class operates asynchronously to enable maximum throughput.
@@ -34,11 +36,11 @@ class Encoder {
typedef int EncodingState;
// DataAvailableCallback is called as blocks of data are made available
- // from the encoder. The callback takes ownership of header and is
- // responsible for deleting it.
- typedef Callback3<const UpdateStreamPacketHeader*,
- const scoped_refptr<media::DataBuffer>&,
- EncodingState>::Type DataAvailableCallback;
+ // from the encoder. Data made available by the encoder is in the form
+ // of HostMessage to reduce the amount of memory copies.
+ // The callback takes ownership of the HostMessage and is responsible for
+ // deleting it.
+ typedef Callback2<HostMessage*, EncodingState>::Type DataAvailableCallback;
virtual ~Encoder() {}
« no previous file with comments | « remoting/host/client_connection_unittest.cc ('k') | remoting/host/encoder_verbatim.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698