Changing UpdateStreamPacket protobuf definition for chromoting

Changing UpdateStreamPacket protobuf definition for chromoting

This code also changes the API for encoder and ClientConnection to eliminate
one less copy.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52561

[Alpha Left Google, 2010-07-12 06:44:01]

This patch will eliminate one copy and pave the way the zlib encoding.

In the next patch I'll move encoders and decoders to base so I can have some
testing utils there.

[dmac, 2010-07-13 00:39:59]

LGTM

Just some comments on comments ;-)

http://codereview.chromium.org/2963003/diff/2001/3003
File remoting/client/decoder.h (right):

http://codereview.chromium.org/2963003/diff/2001/3003#newcode65
remoting/client/decoder.h:65: // HostMessage given by this method will contain a
UpdateStreamPacketMessage.
do you mean returned instead of given?

http://codereview.chromium.org/2963003/diff/2001/3003#newcode99
remoting/client/decoder.h:99: // After receiving UpdateStreaBeginRect, the
encoder will traisist to
do you mean transit instead of traisist? Maybe transform or change is a better
word?

http://codereview.chromium.org/2963003/diff/2001/3003#newcode105
remoting/client/decoder.h:105: // The decoder will transist to
kWaitingForBeginRect if UpdateStreamEndRect
transist?

http://codereview.chromium.org/2963003/diff/2001/3007
File remoting/client/simple_client.cc (right):

http://codereview.chromium.org/2963003/diff/2001/3007#newcode89
remoting/client/simple_client.cc:89: if (!msg.has_begin_rect())
is this an error condition that we want to log?

http://codereview.chromium.org/2963003/diff/2001/3010
File remoting/host/client_connection.h (right):

http://codereview.chromium.org/2963003/diff/2001/3010#newcode66
remoting/host/client_connection.h:66: // object will be responsible for
serializing and frame the message.
s/frame/framing/

[Alpha Left Google, 2010-07-13 19:32:59]

http://codereview.chromium.org/2963003/diff/2001/3007
File remoting/client/simple_client.cc (right):

http://codereview.chromium.org/2963003/diff/2001/3007#newcode89
remoting/client/simple_client.cc:89: if (!msg.has_begin_rect())
On 2010/07/13 00:40:00, dmac wrote:
> is this an error condition that we want to log?

not really, this is just a test application that prints the begin rect.