gclient: update git-cl whenever git-cl is run and not when gclient is run

gclient: update git-cl whenever git-cl is run and not when gclient is run

Rather than updating git-cl whenever gclient is invoked, update it
whenever git-cl is invoked.

In the chromium-os workflow, folks often run git-cl but rarely run gclient.
This results in folks running an older git-cl which may not
have the latest features/fixes.

TEST=

Tested that git-cl is updated when it is stale, git-cl is cloned when it doesn't exist and is not updated when DEPOT_TOOLS_UPDATE=0

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52236

[Daniel Erat, 2010-07-13 22:36:28]

LGTM

[M-A Ruel, 2010-07-15 02:43:57]

git fetch is relatively slow. I'm worried about the slow down on the review
tools. We don't care as much for gclient since syncing is already slow while
many git-cl operations aren't.

Can you quantify the slow down?

On-screen keyboard adds typos to my usual grammar dysfunction.

Le 13 juil. 2010 15:36, <derat@chromium.org> a écrit :
> LGTM
>
> http://codereview.chromium.org/2962013/show

[Mandeep Singh Baines, 2010-07-16 22:03:16]

This will change depending on server load but here's what I get:

(kernel-header)$ time git cl
          Usage: git-cl <command> [options]

Commands are:
  config     edit configuration for this tree
  dcommit    commit the current changelist via git-svn
  help       print list of commands or help for a specific command
  issue      Set or display the current code review issue number.
  patch      patch in a code review
  presubmit  run presubmit tests on the current changelist
  push       commit the current changelist via git
  rebase     rebase current branch on top of svn repo
  status     show status of changelists
  tree       show the status of the tree
  upload     upload the current changelist to codereview
  upstream   print the name of the upstream branch, if any

Options:
  -h, --help  show this help message and exit

real    0m0.563s
user    0m0.080s
sys     0m0.076s
msb@msb:~/chromiumos/src/third_party/chromiumos-overlay
(kernel-header)$ time
/usr/local/google/home/msb/git/depot_tools/git-cl-repo/git-cl
Usage: git-cl <command> [options]

Commands are:
  config     edit configuration for this tree
  dcommit    commit the current changelist via git-svn
  help       print list of commands or help for a specific command
  issue      Set or display the current code review issue number.
  patch      patch in a code review
  presubmit  run presubmit tests on the current changelist
  push       commit the current changelist via git
  rebase     rebase current branch on top of svn repo
  status     show status of changelists
  tree       show the status of the tree
  upload     upload the current changelist to codereview
  upstream   print the name of the upstream branch, if any

Options:
  -h, --help  show this help message and exit

real    0m0.093s
user    0m0.072s
sys     0m0.012s


On Wed, Jul 14, 2010 at 7:43 PM, Marc-Antoine Ruel <maruel@chromium.org> wrote:
> git fetch is relatively slow. I'm worried about the slow down on the review
> tools. We don't care as much for gclient since syncing is already slow while
> many git-cl operations aren't.
>
> Can you quantify the slow down?
>
> On-screen keyboard adds typos to my usual grammar dysfunction.
>
> Le 13 juil. 2010 15:36, <derat@chromium.org> a écrit :
>
>> LGTM
>>
>> http://codereview.chromium.org/2962013/show
>

[Mandeep Singh Baines, 2010-07-16 22:04:33]

folks who care about git-cl latency can always opt-out by setting PATH
appropriately.

On Fri, Jul 16, 2010 at 3:03 PM, Mandeep Singh Baines <msb@chromium.org> wrote:
> This will change depending on server load but here's what I get:
>
> (kernel-header)$ time git cl
>          Usage: git-cl <command> [options]
>
> Commands are:
>  config     edit configuration for this tree
>  dcommit    commit the current changelist via git-svn
>  help       print list of commands or help for a specific command
>  issue      Set or display the current code review issue number.
>  patch      patch in a code review
>  presubmit  run presubmit tests on the current changelist
>  push       commit the current changelist via git
>  rebase     rebase current branch on top of svn repo
>  status     show status of changelists
>  tree       show the status of the tree
>  upload     upload the current changelist to codereview
>  upstream   print the name of the upstream branch, if any
>
> Options:
>  -h, --help  show this help message and exit
>
> real    0m0.563s
> user    0m0.080s
> sys     0m0.076s
> msb@msb:~/chromiumos/src/third_party/chromiumos-overlay
> (kernel-header)$ time
> /usr/local/google/home/msb/git/depot_tools/git-cl-repo/git-cl
> Usage: git-cl <command> [options]
>
> Commands are:
>  config     edit configuration for this tree
>  dcommit    commit the current changelist via git-svn
>  help       print list of commands or help for a specific command
>  issue      Set or display the current code review issue number.
>  patch      patch in a code review
>  presubmit  run presubmit tests on the current changelist
>  push       commit the current changelist via git
>  rebase     rebase current branch on top of svn repo
>  status     show status of changelists
>  tree       show the status of the tree
>  upload     upload the current changelist to codereview
>  upstream   print the name of the upstream branch, if any
>
> Options:
>  -h, --help  show this help message and exit
>
> real    0m0.093s
> user    0m0.072s
> sys     0m0.012s
>
>
> On Wed, Jul 14, 2010 at 7:43 PM, Marc-Antoine Ruel <maruel@chromium.org>
wrote:
>> git fetch is relatively slow. I'm worried about the slow down on the review
>> tools. We don't care as much for gclient since syncing is already slow while
>> many git-cl operations aren't.
>>
>> Can you quantify the slow down?
>>
>> On-screen keyboard adds typos to my usual grammar dysfunction.
>>
>> Le 13 juil. 2010 15:36, <derat@chromium.org> a écrit :
>>
>>> LGTM
>>>
>>> http://codereview.chromium.org/2962013/show
>>
>

[M-A Ruel, 2010-07-17 15:43:05]

On 2010/07/16 22:03:16, Mandeep Singh Baines wrote:
> This will change depending on server load but here's what I get:
> 
> (kernel-header)$ time git cl
>           Usage: git-cl <command> [options]
> 
> Commands are:
>   config     edit configuration for this tree
>   dcommit    commit the current changelist via git-svn
>   help       print list of commands or help for a specific command
>   issue      Set or display the current code review issue number.
>   patch      patch in a code review
>   presubmit  run presubmit tests on the current changelist
>   push       commit the current changelist via git
>   rebase     rebase current branch on top of svn repo
>   status     show status of changelists
>   tree       show the status of the tree
>   upload     upload the current changelist to codereview
>   upstream   print the name of the upstream branch, if any
> 
> Options:
>   -h, --help  show this help message and exit
> 
> real    0m0.563s
> user    0m0.080s
> sys     0m0.076s
> msb@msb:~/chromiumos/src/third_party/chromiumos-overlay
> (kernel-header)$ time
> /usr/local/google/home/msb/git/depot_tools/git-cl-repo/git-cl
> Usage: git-cl <command> [options]
> 
> Commands are:
>   config     edit configuration for this tree
>   dcommit    commit the current changelist via git-svn
>   help       print list of commands or help for a specific command
>   issue      Set or display the current code review issue number.
>   patch      patch in a code review
>   presubmit  run presubmit tests on the current changelist
>   push       commit the current changelist via git
>   rebase     rebase current branch on top of svn repo
>   status     show status of changelists
>   tree       show the status of the tree
>   upload     upload the current changelist to codereview
>   upstream   print the name of the upstream branch, if any
> 
> Options:
>   -h, --help  show this help message and exit
> 
> real    0m0.093s
> user    0m0.072s
> sys     0m0.012s
> 
> 
> On Wed, Jul 14, 2010 at 7:43 PM, Marc-Antoine Ruel
<mailto:maruel@chromium.org> wrote:
> > git fetch is relatively slow. I'm worried about the slow down on the review
> > tools. We don't care as much for gclient since syncing is already slow while
> > many git-cl operations aren't.
> >
> > Can you quantify the slow down?

Half a second on *every* invocation is *a lot*. Imagine if every git invocation
was this slow. It'd be nicer if it was run only once every 3 days like gcl does
for its cache. Doing it at every execution is overkill. We care a lot about
review tool speed.

M-A