Update gyp for chromium multi dll build

Update gyp for chromium multi dll build

BUG=46311
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52614

[darin (slow to review), 2010-07-13 22:03:29]

http://codereview.chromium.org/2962012/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2962012/diff/1/2#newcode479
build/common.gypi:479: 'GURL_DLL',
shouldn't these be defined in an 'export_dependent_settings' section of
WebKit.gyp and googleurl.gyp?

http://codereview.chromium.org/2962012/diff/1/3
File chrome/chrome_renderer.gypi (right):

http://codereview.chromium.org/2962012/diff/1/3#newcode245
chrome/chrome_renderer.gypi:245: ['javascript_engine=="v8" and
component=="shared_library"', {
ditto.  it seems like any project that depends on v8 should automatically get
the USING_V8_SHARED define via 'export_dependent_settings' if we set that up
properly.

[Victor Wang, 2010-07-14 03:34:45]

Did not know it can be done this way. New patch uploaded.

On 2010/07/13 22:03:29, darin wrote:
> http://codereview.chromium.org/2962012/diff/1/2
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/2962012/diff/1/2#newcode479
> build/common.gypi:479: 'GURL_DLL',
> shouldn't these be defined in an 'export_dependent_settings' section of
> WebKit.gyp and googleurl.gyp?
> 
> http://codereview.chromium.org/2962012/diff/1/3
> File chrome/chrome_renderer.gypi (right):
> 
> http://codereview.chromium.org/2962012/diff/1/3#newcode245
> chrome/chrome_renderer.gypi:245: ['javascript_engine=="v8" and
> component=="shared_library"', {
> ditto.  it seems like any project that depends on v8 should automatically get
> the USING_V8_SHARED define via 'export_dependent_settings' if we set that up
> properly.

[darin (slow to review), 2010-07-14 23:18:05]

LGTM

http://codereview.chromium.org/2962012/diff/4002/6001
File build/common.gypi (right):

http://codereview.chromium.org/2962012/diff/4002/6001#newcode482
build/common.gypi:482: 'msvs_disabled_warnings': [4291],
it'd be nice to localize this to the WebKit projects since Chromium code should
not be including any WTF headers.

http://codereview.chromium.org/2962012/diff/4002/6003
File webkit/glue/webkit_glue.gypi (right):

http://codereview.chromium.org/2962012/diff/4002/6003#newcode400
webkit/glue/webkit_glue.gypi:400:
'<(DEPTH)/third_party/WebKit/WebKit/chromium/WebKit.gyp:webkit',
maybe it makes sense to put this in the main dependencies section so that people
see all of the dependencies in one place.

[Victor Wang, 2010-07-15 05:01:10]

On 2010/07/14 23:18:05, darin wrote:
> LGTM
> 
> http://codereview.chromium.org/2962012/diff/4002/6001
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/2962012/diff/4002/6001#newcode482
> build/common.gypi:482: 'msvs_disabled_warnings': [4291],
> it'd be nice to localize this to the WebKit projects since Chromium code
should
> not be including any WTF headers.
Sure, will move this to webkit.
> 
> http://codereview.chromium.org/2962012/diff/4002/6003
> File webkit/glue/webkit_glue.gypi (right):
> 
> http://codereview.chromium.org/2962012/diff/4002/6003#newcode400
> webkit/glue/webkit_glue.gypi:400:
> '<(DEPTH)/third_party/WebKit/WebKit/chromium/WebKit.gyp:webkit',
> maybe it makes sense to put this in the main dependencies section so that
people
> see all of the dependencies in one place.
done

[darin (slow to review), 2010-07-15 06:13:44]

LGTM

[Victor Wang, 2010-07-15 07:02:46]

On 2010/07/15 05:01:10, Victor Wang wrote:
> On 2010/07/14 23:18:05, darin wrote:
> > LGTM
> > 
> > http://codereview.chromium.org/2962012/diff/4002/6001
> > File build/common.gypi (right):
> > 
> > http://codereview.chromium.org/2962012/diff/4002/6001#newcode482
> > build/common.gypi:482: 'msvs_disabled_warnings': [4291],
> > it'd be nice to localize this to the WebKit projects since Chromium code
> should
> > not be including any WTF headers.
> Sure, will move this to webkit.
> > 
> > http://codereview.chromium.org/2962012/diff/4002/6003
> > File webkit/glue/webkit_glue.gypi (right):
> > 
> > http://codereview.chromium.org/2962012/diff/4002/6003#newcode400
> > webkit/glue/webkit_glue.gypi:400:
> > '<(DEPTH)/third_party/WebKit/WebKit/chromium/WebKit.gyp:webkit',
> > maybe it makes sense to put this in the main dependencies section so that
> people
> > see all of the dependencies in one place.
> done
moving this to main dependencies causes failure on mac because of the circular
dependency check. For now, I changed it back to previous version and only add
these dependencies for windows multi dll build.