Use GetSwitchValueASCII.

Use GetSwitchValueASCII.

BUG=24672
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31269

[tfarina (gmail-do not use), 2009-11-02 23:34:43]

Evan, could you take a look at this?

[Evan Martin, 2009-11-02 23:53:01]

On 2009/11/02 23:34:43, tfarina wrote:
> Evan, could you take a look at this?

Hm, I'm having trouble applying the patch:

error: patch failed: chrome/test/memory_test/memory_test.cc:44
error: chrome/test/memory_test/memory_test.cc: patch does not apply
error: patch failed: chrome/browser/extensions/extensions_service.cc:111
error: chrome/browser/extensions/extensions_service.cc: patch does not apply
error: patch failed: chrome/browser/chromeos/external_cookie_handler.cc:17
error: chrome/browser/chromeos/external_cookie_handler.cc: patch does not apply
error: patch failed: chrome/browser/browser_main.cc:446
error: chrome/browser/browser_main.cc: patch does not apply
error: patch failed: chrome/browser/nacl_process_host.cc:116
error: chrome/browser/nacl_process_host.cc: patch does not apply
error: patch failed: chrome/browser/sync/profile_sync_service.cc:212
error: chrome/browser/sync/profile_sync_service.cc: patch does not apply


Oh, I see, it's an old patch?  I think it needs to be updated to trunk.

[tfarina (gmail-do not use), 2009-11-02 23:54:51]

On 2009/11/02 23:53:01, Evan Martin wrote:
> On 2009/11/02 23:34:43, tfarina wrote:
> > Evan, could you take a look at this?
> 
> Hm, I'm having trouble applying the patch:
> 
> error: patch failed: chrome/test/memory_test/memory_test.cc:44
> error: chrome/test/memory_test/memory_test.cc: patch does not apply
> error: patch failed: chrome/browser/extensions/extensions_service.cc:111
> error: chrome/browser/extensions/extensions_service.cc: patch does not apply
> error: patch failed: chrome/browser/chromeos/external_cookie_handler.cc:17
> error: chrome/browser/chromeos/external_cookie_handler.cc: patch does not
apply
> error: patch failed: chrome/browser/browser_main.cc:446
> error: chrome/browser/browser_main.cc: patch does not apply
> error: patch failed: chrome/browser/nacl_process_host.cc:116
> error: chrome/browser/nacl_process_host.cc: patch does not apply
> error: patch failed: chrome/browser/sync/profile_sync_service.cc:212
> error: chrome/browser/sync/profile_sync_service.cc: patch does not apply
> 
> 
> Oh, I see, it's an old patch?  I think it needs to be updated to trunk.

Yeah, that it's old, sorry about that, I will rebase it to ToT.

[tfarina (gmail-do not use), 2009-11-06 12:55:25]

Evan, sorry for the delay.

I rebased it yesterday at night, please take a look.

[tony, 2009-11-06 18:04:57]

On 2009/11/06 12:55:25, tfarina wrote:
> Evan, sorry for the delay.
> 
> I rebased it yesterday at night, please take a look.

Evan is on vacation.  I will run this by the try servers and land it if it
passes.

[tony, 2009-11-06 19:35:44]

LGTM, I will land it when the tree opens.  Thanks!

[tony, 2009-11-06 19:55:27]

r31269

[tfarina (gmail-do not use), 2009-11-06 20:29:44]

On 2009/11/06 19:55:27, tony wrote:
> r31269

Thanks Tony.