Issue 2959014: Implement initial ClipRect....

Issue 2959014: Implement initial ClipRect.... (Closed)

Created:
10 years, 5 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
brettw, sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Implement initial ClipRect. Move IntersectsClipRectInt and GetClipRect functions to CanvasSkia private, since they are only used internally. BUG=none TEST=see unittest. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53218

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -73 lines)			Patch
M	gfx/canvas.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -7 lines	0 comments	Download
M	gfx/canvas_direct2d.h	View	1 2 3 4 5 6 7	2 chunks	+18 lines, -3 lines	0 comments	Download
M	gfx/canvas_direct2d.cc	View	1 2 3 4 5 6 7	4 chunks	+40 lines, -16 lines	0 comments	Download
M	gfx/canvas_direct2d_unittest.cc	View	1 2 3 4 5 6 7	1 chunk	+27 lines, -0 lines	0 comments	Download
M	gfx/canvas_skia.h	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -2 lines	0 comments	Download
M	gfx/canvas_skia.cc	View	1 2 3 4 5 6 7	4 chunks	+18 lines, -25 lines	0 comments	Download
M	views/border.cc	View	5 6 7	1 chunk	+6 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/2959014/diff/16001/4005 File gfx/canvas_direct2d.h (right): http://codereview.chromium.org/2959014/diff/16001/4005#newcode90 gfx/canvas_direct2d.h:90: explicit RenderState(ID2D1Layer* layer) : layer(layer), clip_count(0) {} nit: constructors ...

10 years, 5 months ago (2010-07-14 21:04:45 UTC) #2

brettw

10 years, 5 months ago (2010-07-14 21:26:38 UTC) #4

LGTM

http://codereview.chromium.org/2959014/diff/7002/20004
File gfx/canvas_direct2d.h (right):

http://codereview.chromium.org/2959014/diff/7002/20004#newcode87
gfx/canvas_direct2d.h:87: ID2D1Layer* layer;
How does the memory of this pointer get managed? Can the comment say this?

Expand Messages | Collapse Messages