Issue 2959005: Make optional flag optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2959005: Make optional flag optional (Closed)

Created:
10 years, 5 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

Make optional flag optional Change-Id: I022a0bdf58b4884b0bc8c640b6b543e419743fd1

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	utility/load_kernel_test.c	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM http://codereview.chromium.org/2959005/diff/1/2 File utility/load_kernel_test.c (right): http://codereview.chromium.org/2959005/diff/1/2#newcode123 utility/load_kernel_test.c:123: if (argc == 4) { Might make this ...

10 years, 5 months ago (2010-07-10 00:09:42 UTC) #2

gauravsh

10 years, 5 months ago (2010-07-10 00:35:07 UTC) #3

On Fri, Jul 9, 2010 at 5:09 PM,  <rspangler@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/2959005/diff/1/2
> File utility/load_kernel_test.c (right):
>
> http://codereview.chromium.org/2959005/diff/1/2#newcode123
> utility/load_kernel_test.c:123: if (argc == 4) {
> Might make this >=4, so it'll work if we add a 5th arg...
>
> http://codereview.chromium.org/2959005/show
>

Oh shoot, I misinterpreted the inverted comparison wrong. LGTM, and thanks!


-- 
-g

Expand Messages | Collapse Messages