Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2958016: Give imported bookmarks the properly themed button text.... (Closed)

Created:
10 years, 5 months ago by John Grabowski
Modified:
9 years, 5 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Give imported bookmarks the properly themed button text. BUG=http://crbug.com/46734 TEST=new profile. Open bookmark bar. Install Maria Carey theme. Add a bookmark --> text is white. Import bookmarks --> text of new buttons is also white (not black). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52515

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/cocoa/bookmark_bar_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Grabowski
10 years, 5 months ago (2010-07-14 23:41:14 UTC) #1
dhollowa
http://codereview.chromium.org/2958016/diff/1/2 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/2958016/diff/1/2#newcode1010 chrome/browser/cocoa/bookmark_bar_controller.mm:1010: // the button (e.g. until "now" at the earliest). ...
10 years, 5 months ago (2010-07-14 23:52:14 UTC) #2
John Grabowski
Feedback applied; new diffs up
10 years, 5 months ago (2010-07-15 00:32:08 UTC) #3
dhollowa
10 years, 5 months ago (2010-07-15 00:56:35 UTC) #4
Awesome, thanks.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698