Added RSA key generator for register_host.py

Added RSA key generator for register_host.py
TEST=None
BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52406

[Sergey Ulanov, 2010-07-12 19:24:42]

ping

[awong, 2010-07-14 19:36:32]

LGTM with a couple of nits, and assuming there's no standard RSA key generation
in python.

The wstring + char[] should be fixed in another CL.  Maybe assign it to whoever
wrote those in the first place (alpha? dave? :P).

http://codereview.chromium.org/2958001/diff/9001/10001
File remoting/host/host_config.cc (right):

http://codereview.chromium.org/2958001/diff/9001/10001#newcode9
remoting/host/host_config.cc:9: const std::wstring
kXmppLoginConfigPath(L"xmpp_login");
Ack.  We're not supposed to have wstrings/string/etc., as globals.  Can't we use
char[]?

http://codereview.chromium.org/2958001/diff/9001/10002
File remoting/host/host_config.h (right):

http://codereview.chromium.org/2958001/diff/9001/10002#newcode28
remoting/host/host_config.h:28: extern const std::wstring kPrivateKeyConfigPath;
Tangential note, why are these all wstrings?  Should we use stirng16s?

http://codereview.chromium.org/2958001/diff/9001/10003
File remoting/host/keygen_main.cc (right):

http://codereview.chromium.org/2958001/diff/9001/10003#newcode5
remoting/host/keygen_main.cc:5: // This is a tool used by register_host.py to
generate RSA keypair. It just
...doesn't python have a rsa key generator?

http://codereview.chromium.org/2958001/diff/9001/10003#newcode11
remoting/host/keygen_main.cc:11: #include <cstdio>
stdio.h is more common.

Also C includes go before C++ ones.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

[Sergey Ulanov, 2010-07-14 19:56:55]

http://codereview.chromium.org/2958001/diff/9001/10001
File remoting/host/host_config.cc (right):

http://codereview.chromium.org/2958001/diff/9001/10001#newcode9
remoting/host/host_config.cc:9: const std::wstring
kXmppLoginConfigPath(L"xmpp_login");
On 2010/07/14 19:36:32, awong wrote:
> Ack.  We're not supposed to have wstrings/string/etc., as globals.  Can't we
use
> char[]?
Yes, my bad. Will make another CL to fix this.

http://codereview.chromium.org/2958001/diff/9001/10002
File remoting/host/host_config.h (right):

http://codereview.chromium.org/2958001/diff/9001/10002#newcode28
remoting/host/host_config.h:28: extern const std::wstring kPrivateKeyConfigPath;
On 2010/07/14 19:36:32, awong wrote:
> Tangential note, why are these all wstrings?  Should we use stirng16s?

DictionaryValue works with wstring path only.

http://codereview.chromium.org/2958001/diff/9001/10003
File remoting/host/keygen_main.cc (right):

http://codereview.chromium.org/2958001/diff/9001/10003#newcode5
remoting/host/keygen_main.cc:5: // This is a tool used by register_host.py to
generate RSA keypair. It just
On 2010/07/14 19:36:32, awong wrote:
> ...doesn't python have a rsa key generator?
It does, but only in 2.6, i.e. it wouldn't work on Mac and Windows.

http://codereview.chromium.org/2958001/diff/9001/10003#newcode11
remoting/host/keygen_main.cc:11: #include <cstdio>
On 2010/07/14 19:36:32, awong wrote:
> stdio.h is more common.
> 
> Also C includes go before C++ ones.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

Done.