Issue 2957014: Fix SafeMemcmp by removing any potential data-dependent branches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2957014: Fix SafeMemcmp by removing any potential data-dependent branches. (Closed)

Created:
10 years, 5 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Fix SafeMemcmp by removing any potential data-dependent branches. Credit: Nate Lawson of Root Labs

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	firmware/stub/utility_stub.c	View	1	1 chunk	+10 lines, -6 lines	0 comments	Download
	M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

LGTM