Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: src/debug.cc

Issue 2957: Defer the writing of the source position data to the relocation information... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codegen-ia32.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
===================================================================
--- src/debug.cc (revision 330)
+++ src/debug.cc (working copy)
@@ -94,14 +94,16 @@
first = false;
if (RinfoDone()) return;
- // Update the current source position each time a source position is
- // passed.
+ // Whenever a statement position or (plain) position is passed update the
+ // current value of these.
if (is_position(rmode())) {
- position_ = rinfo()->data() - debug_info_->shared()->start_position();
if (is_statement_position(rmode())) {
statement_position_ =
rinfo()->data() - debug_info_->shared()->start_position();
}
+ // Always update the position as we don't want that to be before the
+ // statement position.
+ position_ = rinfo()->data() - debug_info_->shared()->start_position();
ASSERT(position_ >= 0);
ASSERT(statement_position_ >= 0);
}
@@ -978,7 +980,7 @@
int current_statement_position =
break_location_iterator->code()->SourceStatementPosition(frame->pc());
return thread_local_.last_fp_ == frame->fp() &&
- thread_local_.last_statement_position_ == current_statement_position;
+ thread_local_.last_statement_position_ == current_statement_position;
}
// No step next action - don't continue.
« no previous file with comments | « src/codegen-ia32.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698