Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2956005: Adds MapBufferSubData and MapTexSubImage2D.... (Closed)

Created:
10 years, 5 months ago by greggman
Modified:
9 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Adds MapBufferSubData and MapTexSubImage2D. This is only the internal command buffer implementation. Connecting these functions publicly to PPAPI or whatever will happen separate from this CL. It's not clear to me where to put GL_READ_ONLY and GL_WRITE_ONLY Probably the same place we expose these 2 functions to the public. TEST=unit test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52263

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1059 lines, -37 lines) Patch
M gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/GLES2/gles2_command_buffer.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 13 chunks +55 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator.h View 1 4 chunks +12 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator.cc View 1 3 chunks +19 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 4 5 6 7 8 9 4 chunks +100 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 5 6 3 chunks +102 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 3 chunks +186 lines, -1 line 0 comments Download
A gpu/command_buffer/client/mapped_memory.h View 2 3 1 chunk +146 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/mapped_memory.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/mapped_memory_unittest.cc View 2 3 4 5 1 chunk +257 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
10 years, 5 months ago (2010-07-12 23:12:12 UTC) #1
apatrick_chromium
LGTM http://codereview.chromium.org/2956005/diff/1/4 File gpu/command_buffer/client/fenced_allocator.cc (right): http://codereview.chromium.org/2956005/diff/1/4#newcode162 gpu/command_buffer/client/fenced_allocator.cc:162: Block& block = blocks_[i]; const Block& http://codereview.chromium.org/2956005/diff/1/6 File ...
10 years, 5 months ago (2010-07-12 23:34:38 UTC) #2
greggman
I forgot 3 files. Can you check over them? They are mapped_memory.cc mapped_memory.h mapped_memory_unittest.cc http://codereview.chromium.org/2956005/diff/1/4 ...
10 years, 5 months ago (2010-07-13 00:12:38 UTC) #3
apatrick_chromium
10 years, 5 months ago (2010-07-13 00:34:00 UTC) #4
LGTM

http://codereview.chromium.org/2956005/diff/7002/17011
File gpu/command_buffer/client/mapped_memory.h (right):

http://codereview.chromium.org/2956005/diff/7002/17011#newcode92
gpu/command_buffer/client/mapped_memory.h:92: pointer < reinterpret_cast<const
char*>(shm_.ptr) + shm_.size;
char->int8

http://codereview.chromium.org/2956005/diff/7002/17012
File gpu/command_buffer/client/mapped_memory_unittest.cc (right):

http://codereview.chromium.org/2956005/diff/7002/17012#newcode75
gpu/command_buffer/client/mapped_memory_unittest.cc:75: #ifndef COMPILER_MSVC
Can you change this to _MSC_VER so it works with my upcoming CL?

Powered by Google App Engine
This is Rietveld 408576698