Issue 2956002: Pepper v2 Font API browser implementation.

Issue 2956002: Pepper v2 Font API browser implementation. (Closed)

Created:
10 years, 5 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pepper v2 Font API browser implementation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52009

Patch Set 4 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -5 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_glue.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/renderer/renderer_sandbox_support_linux.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/renderer_sandbox_support_linux.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	webkit/glue/plugins/pepper_font.h	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_font.cc	View	1 2 3	1 chunk	+100 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.cc	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource.h	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.h	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/support/webkit_support_glue.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/2956002/diff/1/5 File webkit/glue/plugins/pepper_font.cc (right): http://codereview.chromium.org/2956002/diff/1/5#newcode6 webkit/glue/plugins/pepper_font.cc:6: #include <unistd.h> This should be below the pepper_font.h include. ...

10 years, 5 months ago (2010-07-09 05:33:14 UTC) #2

jam

10 years, 5 months ago (2010-07-09 06:10:08 UTC) #3

done

On Thu, Jul 8, 2010 at 10:33 PM, <brettw@chromium.org> wrote:

>
> http://codereview.chromium.org/2956002/diff/1/5
> File webkit/glue/plugins/pepper_font.cc (right):
>
> http://codereview.chromium.org/2956002/diff/1/5#newcode6
> webkit/glue/plugins/pepper_font.cc:6: #include <unistd.h>
> This should be below the pepper_font.h include. Also, you should include
> build/build_config to get the values of OS_LINUX.
>
> http://codereview.chromium.org/2956002/diff/1/5#newcode40
> webkit/glue/plugins/pepper_font.cc:40: return false;
> Should there be a TODO here to implement on other platforms? Or is this
> not needed? If the latter, a comment explaining why would be a good
> idea.
>
> http://codereview.chromium.org/2956002/diff/1/6
> File webkit/glue/plugins/pepper_font.h (right):
>
> http://codereview.chromium.org/2956002/diff/1/6#newcode16
> webkit/glue/plugins/pepper_font.h:16: class Font : public Resource  {
> Extra space before the {
>
>
> http://codereview.chromium.org/2956002/show
>

Expand Messages | Collapse Messages