Issue 2951015: Attempt to fix the chrome frame net tests failures on the builders. There see...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2951015: Attempt to fix the chrome frame net tests failures on the builders. There see... (Closed)

Created:
10 years, 5 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Attempt to fix the chrome frame net tests failures on the builders. There seems to be a race condition causing the tests to hang on startup on the builder. It appears that on chrome frame net tests startup we process an initial HTTP head request in the test automation provider factory and end up sending this as the response to IE instead of the expected dummy chrome frame page. This causes the tests to hang. Fix is to also check for a valid tab handle in the test automation provider factory instead of just asserting for the same. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52280

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome_frame/test/net/test_automation_provider.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

thanks for debugging this!
lgtm

Expand Messages | Collapse Messages