Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: chrome/browser/cocoa/browser_accessibility.h

Issue 2951011: Readability review for Obj-C for feldstein (Closed)
Patch Set: Revert changes to other file Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/browser_accessibility.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_accessibility.h
diff --git a/chrome/browser/cocoa/browser_accessibility.h b/chrome/browser/cocoa/browser_accessibility.h
index f891327b24d4f608994a937b32aa75383cd355f0..7ac68948e2f591b2a145e30e7c72e3f4cee844d6 100644
--- a/chrome/browser/cocoa/browser_accessibility.h
+++ b/chrome/browser/cocoa/browser_accessibility.h
@@ -8,15 +8,15 @@
#import <Cocoa/Cocoa.h>
#import "base/scoped_nsobject.h"
-#include "chrome/browser/cocoa/browser_accessibility_delegate.h"
+#import "chrome/browser/cocoa/browser_accessibility_delegate.h"
#include "webkit/glue/webaccessibility.h"
using webkit_glue::WebAccessibility;
// BrowserAccessibility is a cocoa wrapper around the WebAccessibility
// object. The renderer converts webkit's accessibility tree into a
-// WebAccessibility tree and passes it to us over IPC. This class
-// converts it into a format Cocoa can query.
+// WebAccessibility tree and passes it to the browser process over IPC.
+// This class converts it into a format Cocoa can query.
@interface BrowserAccessibility : NSObject {
@private
WebAccessibility webAccessibility_;
@@ -24,17 +24,31 @@ using webkit_glue::WebAccessibility;
scoped_nsobject<NSMutableArray> children_;
// The parent of the accessibility object. This can be another
// BrowserAccessibility or a RenderWidgetHostViewCocoa.
- id parent_;
+ id parent_; // weak
}
-- (id)initWithObject:(const WebAccessibility)accessibility
+// This creates a cocoa browser accessibility object around
+// the webkit glue WebAccessibility object. The delegate is
+// used to communicate with the host renderer. None of these
+// parameters can be null.
+- (id)initWithObject:(const WebAccessibility&)accessibility
delegate:(id<BrowserAccessibilityDelegate>)delegate
parent:(id)parent;
+// Children is an array of BrowserAccessibility objects, representing
+// the accessibility children of this object.
@property(nonatomic, readonly) NSArray* children;
+// isIgnored returns whether or not the accessibility object
+// should be ignored by the accessibility hierarchy.
@property(nonatomic, readonly, getter=isIgnored) BOOL ignored;
+// The origin of this object in the page's document.
+// This is relative to webkit's top-left origin, not Cocoa's
+// bottom-left origin.
@property(nonatomic, readonly) NSPoint origin;
+// A string indicating the role of this object as far as accessibility
+// is concerned.
@property(nonatomic, readonly) NSString* role;
+// The size of this object.
@property(nonatomic, readonly) NSSize size;
@end
« no previous file with comments | « no previous file | chrome/browser/cocoa/browser_accessibility.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698