Issue 2951002: Fix makefiles to work with ebuild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2951002: Fix makefiles to work with ebuild (Closed)

Created:
10 years, 5 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Fix makefiles to work with ebuild

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/Makefile	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 5 months ago (2010-07-08 22:27:52 UTC) #2

LGTM

On Thu, Jul 8, 2010 at 3:26 PM,  <rspangler@chromium.org> wrote:
> Reviewers: Luigi Semenzato,
>
> Description:
> Fix makefiles to work with ebuild
>
> Please review this at http://codereview.chromium.org/2951002/show
>
> SVN Base: ssh://gitrw.chromium.org/vboot_reference.git
>
> Affected files:
>  M Makefile
>  M tests/Makefile
>
>
> Index: Makefile
> diff --git a/Makefile b/Makefile
> index
>
70bf036470a3a6effb3874bd610f1118f7c23621..638d512ad96698d6e240ab325bfe42a63d7e1d16
> 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -35,7 +35,7 @@ clean:
>  install:
>        $(MAKE) -C utility install
>        $(MAKE) -C cgpt install
> -#      $(MAKE) -C tests install
> +       $(MAKE) -C tests install
>
>  runtests:
>        $(MAKE) -C tests runtests
> Index: tests/Makefile
> diff --git a/tests/Makefile b/tests/Makefile
> index
>
ed37e73e7751ecc4b8e53b4ea776614a43369410..957e9bbf70bc21f8f010feef6d65aeeb6f322e7e
> 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -101,6 +101,9 @@ runtests: genkeys runcgpttests runcryptotests
> runmisctests
>  #      ${BUILD_ROOT}/firmware_rollback_tests
>  #      ${BUILD_ROOT}/kernel_rollback_tests
>
> +# Must have a dummy install target for ebuild
> +install:
> +
>  #install: $(BUILD_ROOT)/rollback_index_test
>  #      mkdir -p $(DESTDIR)
>  #      cp -f $(BUILD_ROOT)/rollback_index_test $(DESTDIR)
>
>
>

Expand Messages | Collapse Messages