DevTools: report correct content length for resources

DevTools: report correct content length for resources.

Currently lengthReceived always has the same value as dataLength when Safari calls ResourceHandle::didReceiveData. In Chrome expected content length is passed as lengthReceived parameter which leads to incorrect content length to be stored in InspectorResource. InspectorResource expects lengthReceived to be the length of current data chunk(see InspectorResource::addLength). So I changed lengthReceived parameter to be dataLength.

Darin, I see your TODO comment at line 581 in  http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296 (the comment was deleted later) so I think you are right person to review the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and feel free to leave devtools specific changes to Alex and Pavel.

BUG=25213
TEST=DevToolsSanityTest.TestResourceContentLength

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30725

[darin (slow to review), 2009-10-27 16:10:49]

http://codereview.chromium.org/295041/diff/2001/3001
File webkit/glue/weburlloader_impl.cc (right):

http://codereview.chromium.org/295041/diff/2001/3001#newcode475
Line 475: client_->didReceiveData(loader_, data, len, len);
please also change WebURLLoaderClient to eliminate this parameter.

[yurys, 2009-10-28 12:05:52]

http://codereview.chromium.org/295041/diff/2001/3001
File webkit/glue/weburlloader_impl.cc (right):

http://codereview.chromium.org/295041/diff/2001/3001#newcode475
Line 475: client_->didReceiveData(loader_, data, len, len);
On 2009/10/27 16:10:49, darin wrote:
> please also change WebURLLoaderClient to eliminate this parameter.

Done. I removed totalDataLength parameter from
WebURLLoaderClient::didReceiveData and changed implementors of
WebURLLoaderClient appropriately.

[darin (slow to review), 2009-11-02 17:49:39]

LGTM

http://codereview.chromium.org/295041/diff/6001/6005
File webkit/api/src/ResourceHandle.cpp (right):

http://codereview.chromium.org/295041/diff/6001/6005#newcode138
Line 138: // TODO(yurys): it looks like lengthReceived is always the same as
This should be a FIXME per webkit style.  Can you please file a webkit bug about
this issue.

[yurys, 2009-11-02 18:37:43]

http://codereview.chromium.org/295041/diff/6001/6005
File webkit/api/src/ResourceHandle.cpp (right):

http://codereview.chromium.org/295041/diff/6001/6005#newcode138
Line 138: // TODO(yurys): it looks like lengthReceived is always the same as
On 2009/11/02 17:49:39, darin wrote:
> This should be a FIXME per webkit style.  Can you please file a webkit bug
about
> this issue.

Done. Filed a WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=31019