Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/cocoa/autocomplete_text_field_cell.h

Issue 295036: [Mac] Simplify field editor code which tracks whether editor rect changed. (Closed)
Patch Set: Pinks comments. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/autocomplete_text_field_cell.h
diff --git a/chrome/browser/cocoa/autocomplete_text_field_cell.h b/chrome/browser/cocoa/autocomplete_text_field_cell.h
index fdf4e1e2add0b51f1e1561b7b4655febf458ee8b..e158e4adcf0fd8a350c9dee79517778467632ad0 100644
--- a/chrome/browser/cocoa/autocomplete_text_field_cell.h
+++ b/chrome/browser/cocoa/autocomplete_text_field_cell.h
@@ -15,14 +15,6 @@
// on the right-hand side), the keyword hint ("Press [Tab] to search
// Engine" on the right-hand side), and keyword mode ("Search Engine:"
// in a button-like token on the left-hand side).
-//
-// The cell arranges the field-editor's placement via the standard
-// -editWithFrame:* and -selectWithFrame:* methods. When the visible
-// decoration changes, the cell's look may change, and if the cell is
-// currently being edited the field editor will require adjustment.
-// The cell signals this requirement by returning YES for
-// -fieldEditorNeedsReset, which is used by AutocompleteTextField's
-// -resetFieldEditorFrameIfNeeded in testing if re-layout is needed.
@interface AutocompleteTextFieldCell : NSTextFieldCell {
@private
@@ -34,10 +26,6 @@
// side of the field. Exclusive WRT |keywordString_|;
scoped_nsobject<NSAttributedString> hintString_;
- // YES if the info cell has been changed in a way which would result
- // in the cell needing to be laid out again.
- BOOL fieldEditorNeedsReset_;
-
// Icon that represents the state of the SSL connection
scoped_nsobject<NSImage> hintIcon_;
@@ -47,12 +35,6 @@
scoped_nsobject<NSAttributedString> hintIconLabel_;
}
-@property BOOL fieldEditorNeedsReset;
-
-// The following setup |keywordString_| or |hintString_| based on the
-// input, and set |fieldEditorNeedsReset_| if the layout of the field
-// changed.
-
// Chooses |partialString| if |width| won't fit |fullString|. Strings
// must be non-nil.
- (void)setKeywordString:(NSString*)fullString
« no previous file with comments | « chrome/browser/cocoa/autocomplete_text_field.mm ('k') | chrome/browser/cocoa/autocomplete_text_field_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698