Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 295003: Make backspace not go back while IME is active. (Closed)
Patch Set: s/skip/skip_in_browser/ Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ime_input.cc ('k') | chrome/browser/tab_contents/tab_contents_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
index 4a05273f36a27d9b9c0058d9d169bfe13498a09b..f19243bd3c1fd7f2128b34f714c5d12a25953ec8 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
@@ -588,8 +588,11 @@ void RenderWidgetHostViewMac::SetBackground(const SkBitmap& background) {
// while an input method is composing a text.
// Gmail checks this code in its onkeydown handler to stop auto-completing
// e-mail addresses while composing a CJK text.
- if ([theEvent type] == NSKeyDown && renderWidgetHostView_->im_composing_)
- event.windowsKeyCode = 0xE5;
+ if ([theEvent type] == NSKeyDown && renderWidgetHostView_->im_composing_) {
+ event.windowsKeyCode = 0xE5; // VKEY_PROCESSKEY
+ event.setKeyIdentifierFromWindowsKeyCode();
+ event.skip_in_browser = true;
+ }
// Dispatch this keyboard event to the renderer.
if (renderWidgetHostView_->render_widget_host_) {
« no previous file with comments | « chrome/browser/ime_input.cc ('k') | chrome/browser/tab_contents/tab_contents_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698