Issue 2950009: Check for NULL host_ or frontend_ in the sync_backend_host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2950009: Check for NULL host_ or frontend_ in the sync_backend_host. (Closed)

Created:
10 years, 5 months ago by albertb

Modified:
9 years, 3 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Description

Check for NULL host_ or frontend_ in the sync_backend_host. BUG=49120 TEST=manually tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52421

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/sync/glue/sync_backend_host.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

10 years, 5 months ago (2010-07-14 23:54:27 UTC) #2

LGTM

On Wed, Jul 14, 2010 at 4:42 PM, <albertb@chromium.org> wrote:

> Reviewers: timsteele,
>
> Description:
> Check for NULL host_ or frontend_ in the sync_backend_host.
>
> BUG=49120
> TEST=manually tested
>
> Please review this at http://codereview.chromium.org/2950009/show
>
> Affected files:
>  M chrome/browser/sync/glue/sync_backend_host.cc
>
>
> Index: chrome/browser/sync/glue/sync_backend_host.cc
> diff --git a/chrome/browser/sync/glue/sync_backend_host.cc
> b/chrome/browser/sync/glue/sync_backend_host.cc
> index
>
d6796292c230fb6af66bd130c79837bbc1c37423..435ff436b8d74babe5118f01c5897da6c41f1809
> 100644
> --- a/chrome/browser/sync/glue/sync_backend_host.cc
> +++ b/chrome/browser/sync/glue/sync_backend_host.cc
> @@ -538,10 +538,14 @@ void
> SyncBackendHost::Core::OnInitializationComplete() {
>  }
>
>  void SyncBackendHost::Core::HandleInitalizationCompletedOnFrontendLoop() {
> +  if (!host_)
> +    return;
>   host_->HandleInitializationCompletedOnFrontendLoop();
>  }
>
>  void SyncBackendHost::HandleInitializationCompletedOnFrontendLoop() {
> +  if (!frontend_)
> +    return;
>   frontend_->OnBackendInitialized();
>  }
>
> @@ -598,6 +602,8 @@ void SyncBackendHost::Core::OnStopSyncingPermanently()
> {
>  }
>
>  void SyncBackendHost::Core::HandleStopSyncingPermanentlyOnFrontendLoop() {
> +  if (!host_ || !host_->frontend_)
> +    return;
>   host_->frontend_->OnStopSyncingPermanently();
>  }
>
>
>
>

Expand Messages | Collapse Messages