Issue 2949002: Add "save credit card info?" infobar for Autofill....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2949002: Add "save credit card info?" infobar for Autofill.... (Closed)

Created:
10 years, 5 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add "save credit card info?" infobar for Autofill. BUG=http://crbug.com/48114 TEST=none (depends on bug 47428) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51908

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -13 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+9 lines, -6 lines	0 comments	Download
A	chrome/browser/autofill/autofill_cc_infobar_delegate.h	View	1	1 chunk	+48 lines, -0 lines	1 comment	Download
A	chrome/browser/autofill/autofill_cc_infobar_delegate.cc	View		1 chunk	+106 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.cc	View		3 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.h	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

10 years, 5 months ago (2010-07-08 22:03:40 UTC) #3

Sorry, forgot this comment:

http://codereview.chromium.org/2949002/diff/8001/9003
File chrome/browser/autofill/autofill_cc_infobar_delegate.h (right):

http://codereview.chromium.org/2949002/diff/8001/9003#newcode39
chrome/browser/autofill/autofill_cc_infobar_delegate.h:39: // The browser.
Add another space before this comment.

Expand Messages | Collapse Messages